GdbServer: Fixes crash on gdb detach #3319
Conversation
GdbServer object was getting deleted before the socket thread was shutdown which was causing a crash on detach. Now on destructor it will wait for the thread to thread to exit.
| @@ -127,8 +127,12 @@ void GdbServer::WaitForThreadWakeup() { | |||
| } | |||
|
|
|||
| GdbServer::~GdbServer() { | |||
| CloseListenSocket(); | |||
There was a problem hiding this comment.
Since OpenListenSocket is running at the start of the GDB server thread, is there potential for a race condition for short-lived FEX processes here?
There was a problem hiding this comment.
Not currently since gdbserver always forces processes to wait for gdb attach currently.
There was a problem hiding this comment.
Does it? I see GDBServer::GDBServer() ending in a call to StartThread, so the caller can immediately close it after. Is there external logic that does this waiting?
There was a problem hiding this comment.
Is there external logic that does this waiting?
Yes.
https://github.com/FEX-Emu/FEX/blob/main/FEXCore/Source/Interface/Core/Core.cpp#L331
There was a problem hiding this comment.
Fair enough, thanks for clarifying!
GdbServer object was getting deleted before the socket thread was shutdown which was causing a crash on detach.
Now on destructor it will wait for the thread to thread to exit.