Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPUID: Call handler functions directly #1417

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

lioncash
Copy link
Contributor

@lioncash lioncash commented Dec 2, 2021

Given the calls are all internal, we can store the function pointers directly and call them with the this pointer instead of indirecting through std::bind and std::function.

Given the calls are all internal, we can store the function pointers
directly and call them with the this pointer instead of indirecting
through std::bind and std::function.
Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@Sonicadvance1 Sonicadvance1 merged commit ffee22d into FEX-Emu:main Dec 2, 2021
@lioncash lioncash deleted the cpuid branch December 2, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants