jit/arm64: COND_FGT should map to gt, not hi, as it is not FGTU #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
approved these changes
Nov 25, 2021
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Dec 8, 2021
As a continuation to FEX-Emu#1404, this was mapped to the incorrect Arm64 flags
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Dec 8, 2021
As a continuation to FEX-Emu#1404 these unit tests were needing to be added. This tests both select and conditional branch merging for integer ops and float ops. This is what discovered the issue fixed in f2de640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1127
Finally.
I ended up taking the extremely long road on bisecting this, as I didn't validate that fcmp-eflag-bypass wasn't a culprit leading to me doing a full on bisection of steam, then proceeded to make a race condition bug in the bisection code, then went down the path of chasing that race in the guest code.
But, it's fixed. FIXED :D
Upside: We have amazing new tooling for bisections.
Will follow up with tooling PR