IR: Add handling for ANDN operations #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
force-pushed
the
bic
branch
4 times, most recently
from
ec6c3a0
to
6b19868
Compare
lioncash
force-pushed
the
bic
branch
2 times, most recently
from
392aab4
to
9f77187
Compare
This is a pretty straightforward operation that can be nicely modeled by the BIC instruction on ARMv8, which is nice since we can get rid of the need to manually perform the And and Not operations.
Now that we have the handling in place, we can make use of it to simplify some operations and resolve some lingering TODO comments.
Sonicadvance1
approved these changes
Nov 3, 2021
|
Both BIC(Binary Clear) and ANDN make sense here. I don't have a preference of one name versus the other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few parts of the OpcodeDecoder there's comments about making use of BIC. Given that, we can introduce the Andn IR operation that performs the same behavior as it.
I've named it
Andn, since I feel it's more straightforward to read at a glance, but if it's preferable to name itBic, I'm not opposed to changing it.First time adding an IR op, so if anything looks wonky, just let me know and I'll fix it.