Homework 4 submission for Dylan Graham #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmjames
reviewed
Oct 12, 2017
| } | ||
|
|
||
| function clearInput() { | ||
| $("#city-type").val(""); |
There was a problem hiding this comment.
@dylantg if you use toLowerCase() it willl cover if the input was entered with a upper case.
There was a problem hiding this comment.
I have var cleanedSearchInput = searchInput.trim().toLowerCase(); on Line 16 to allow for various inputs.
rmjames
reviewed
Oct 12, 2017
| } | ||
| // If no match, give an alert, remove background image, and clear the input | ||
| else { | ||
| alert("Sorry, we don't recognize input: " + searchInput + "\n Try again"); |
There was a problem hiding this comment.
@dylantg nice to have an error message 💯
|
@dylantg excellent work on your assignment 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.