Homework submission from Anastasia Schultis #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmjames
reviewed
Oct 17, 2017
js/app.js
Outdated
|
|
||
| // Create a function for the Submit buttom | ||
| function changeCity() { | ||
| console.log("clicked on Submit button") |
rmjames
reviewed
Oct 17, 2017
js/app.js
Outdated
|
|
||
| // use else or else if when you type in city name | ||
| // specify lowercase/uppercase for the cities | ||
| // if() { |
rmjames
reviewed
Oct 17, 2017
js/app.js
Outdated
| // } else if() { | ||
|
|
||
| if (city === "New York" || city === "NYC" || city === "New York City") { | ||
| $('body').css('background-image', "url('images/nyc.jpg')"); |
There was a problem hiding this comment.
@Schultisal the is an extra " next to url 🔨
rmjames
reviewed
Oct 17, 2017
js/app.js
Outdated
|
|
||
| if (city === "New York" || city === "NYC" || city === "New York City") { | ||
| $('body').css('background-image', "url('images/nyc.jpg')"); | ||
| console.log("changed to NYC"); |
rmjames
reviewed
Oct 17, 2017
js/app.js
Outdated
|
|
||
| else (city === "San Francisco" || city === "SF") { | ||
| $('body').css('background-image',"url('images/sf.jpg'); | ||
| console.log("Changed to SF"); |
|
@Schultisal good work on the assignment, just make a note of the comments |
all the pictures work for UpperCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.