Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dataset subset to read in path to rhv #985

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow dataset subset to read in path to rhv #985

wants to merge 3 commits into from

Conversation

mshuaibii
Copy link
Collaborator

Allow users to provide a text file for rhv rather than inputing them directly in config. Mainly helpful for OC20 if you want to filter on sids when there's 600k+.

@mshuaibii mshuaibii requested review from misko and rayg1234 January 29, 2025 22:27
@mshuaibii mshuaibii added enhancement New feature or request patch Patch version release labels Jan 29, 2025
@mshuaibii mshuaibii changed the title rhv_txt Allow dataset subset to read in path to rhv Jan 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/fairchem/core/datasets/base_dataset.py 92.85% <100.00%> (+0.29%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misko misko Awaiting requested review from misko

@rayg1234 rayg1234 Awaiting requested review from rayg1234

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mshuaibii