Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make eqv2 old to hydra converter work with old old configs :'( #856

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Make eqv2 old to hydra converter work with old old configs :'( #856

merged 3 commits into from
Oct 25, 2024

Conversation

misko
Copy link
Collaborator

@misko misko commented Sep 17, 2024 •
edited
Loading

There is two layers of 'module' prefixed on old old eqv2 checkpoints. This works around them while also supporting newer versions. 🤞

@misko misko requested a review from lbluque September 17, 2024 00:01
@misko misko changed the title make it work with old checkpoints Make eqv2 old to hydra converter work with old old configs :'( Sep 17, 2024
@misko misko added enhancement New feature or request patch Patch version release labels Sep 17, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...em/core/models/equiformer_v2/eqv2_to_eqv2_hydra.py 75.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
...em/core/models/equiformer_v2/eqv2_to_eqv2_hydra.py 92.72% <75.00%> (-5.24%) ⬇️

@misko misko added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 7c82af9 Oct 25, 2024
8 checks passed
@misko misko deleted the support_old_equiv2_model_surgery_script branch October 25, 2024 00:31
misko added a commit that referenced this pull request Jan 17, 2025
@misko
make it work with old checkpoints (#856)
0109e21 
Former-commit-id: 393a423efec732ad1c4f9bb3caa44928a3c25d65
beomseok-kang pushed a commit to beomseok-kang/fairchem that referenced this pull request Jan 27, 2025
@misko
make it work with old checkpoints (FAIR-Chem#856)
7469108 
Former-commit-id: 4a821ce4d0156c41c7e71b3037b7b05d8e9da1f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbluque lbluque lbluque approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misko @lbluque