Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs test on submit only #774

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Conversation

lbluque
Copy link
Collaborator

@lbluque lbluque commented Jul 18, 2024

Building docs takes a while. Only trigger the build on PR review submit, not on edit.

@lbluque lbluque requested review from zulissi, mshuaibii and rayg1234 and removed request for mshuaibii July 18, 2024 18:49
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

rayg1234
rayg1234 previously approved these changes Jul 18, 2024
@mshuaibii mshuaibii dismissed rayg1234’s stale review July 18, 2024 23:36

The merge-base changed after approval.

Copy link
Collaborator

@zulissimeta zulissimeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zulissimeta zulissimeta added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 6513ce4 Jul 19, 2024
7 checks passed
@zulissimeta zulissimeta deleted the build-docs-test-on-submit-only branch July 19, 2024 13:35
misko pushed a commit that referenced this pull request Jan 17, 2025
* adding new notebook for using fairchem models with NEBs without CatTSunami enumeration (#764)

* adding new notebook for using fairchem models with NEBs

* adding md tutorials

* blocking code cells that arent needed or take too long

* trigger docs build only on PR review submit

---------

Co-authored-by: Brook Wander <[email protected]>
Co-authored-by: Muhammed Shuaibi <[email protected]>
Former-commit-id: f56f723446547afb7b6b7846b33b5843548701ab
beomseok-kang pushed a commit to beomseok-kang/fairchem that referenced this pull request Jan 27, 2025
* adding new notebook for using fairchem models with NEBs without CatTSunami enumeration (FAIR-Chem#764)

* adding new notebook for using fairchem models with NEBs

* adding md tutorials

* blocking code cells that arent needed or take too long

* trigger docs build only on PR review submit

---------

Co-authored-by: Brook Wander <[email protected]>
Co-authored-by: Muhammed Shuaibi <[email protected]>
Former-commit-id: 1367cd144fb702a8dd9d568a06e8cac791a27d12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants