Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slurm qos setting #757

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Add slurm qos setting #757

merged 3 commits into from
Jul 11, 2024

Conversation

rayg1234
Copy link
Collaborator

@rayg1234 rayg1234 commented Jul 10, 2024

FAIRCluster uses partitions while AWS uses slurm-account and slurm-qos (https://docs.google.com/document/d/19AJC5sL17t4f2zzn6ylW6-mO0CGeONs8ogKprMrWNxA/edit#heading=h.lbn5dlaajt5m)

For FAIRCluster use:
slurm-partition: {ocp, learnfair, etc..}

For AWS:
slurm-partition: learn
slurm-account: ocp
slurm-qos: {ocp_high, lowest}

@rayg1234 rayg1234 changed the title add slurm qos setting [WIP] add slurm qos setting Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/fairchem/core/_cli.py 64.51% <ø> (ø)
src/fairchem/core/common/flags.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@rayg1234 rayg1234 changed the title [WIP] add slurm qos setting Add slurm qos setting Jul 11, 2024
@rayg1234 rayg1234 requested review from misko, mshuaibii and wood-b and removed request for misko July 11, 2024 17:24
@rayg1234 rayg1234 added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 7c3f0d2 Jul 11, 2024
3 checks passed
@rayg1234 rayg1234 deleted the rgao_add_qos branch July 11, 2024 17:39
levineds pushed a commit that referenced this pull request Jul 11, 2024
* add slurm qos setting

* set defaults to none
@rayg1234 rayg1234 added the enhancement New feature or request label Aug 13, 2024
misko pushed a commit that referenced this pull request Jan 17, 2025
* add slurm qos setting

* set defaults to none

Former-commit-id: 57d2187d733215a6f1b67342d7b27965cf263d13
beomseok-kang pushed a commit to beomseok-kang/fairchem that referenced this pull request Jan 27, 2025
* add slurm qos setting

* set defaults to none

Former-commit-id: 871dc81cc2ba7b60af899168c220af1ce0861c08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants