Try removing importlib - breaks multiprocess pickling #746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib is breaking multiprocess pickling.
pytest locally works for tests that uses python multiprocess:
eg:
pytest tests/core/common/test_gp_utils.py
(from eq2_graph_parallel branch)but on CI, which uses
./packages/fairchem-core/pyproject.toml
was breaking with errors like:I traced this back to the option
--import-mode importlib
in the pytesttool.pytest.ini_options
config. This somehow prevents pickling python modules correctly. I tried disabling this seems have no effect on tests and creates more consistency between local development and CI.