-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(OTF) Normalization and element references #715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mshuaibii @misko @wood-b finally here are some validation training runs, we should be set to go now! |
misko
previously approved these changes
Aug 2, 2024
wood-b
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great job pushing this through and thanks for the validation!
lbluque
added a commit
that referenced
this pull request
Aug 6, 2024
(cherry picked from commit 029d4d3)
lbluque
added a commit
that referenced
this pull request
Aug 6, 2024
(cherry picked from commit 029d4d3)
zulissimeta
added
enhancement
New feature or request
minor
Minor version release
labels
Aug 13, 2024
misko
pushed a commit
that referenced
this pull request
Jan 17, 2025
* denorm targets in _forward only * linear reference class * atomref in normalizer * raise input error * clean up normalizer interface * add element refs * add element refs correctly * ruff * fix save_checkpoint * reference and dereference * 2xnorm linref trainer add * clean-up * otf linear reference fit * fix tensor device * otf element references and normalizers * use only present elements when fitting * lint * _forward norm and derefd values * fix list of paths in src * total mean and std * fitted flag to avoid refitting normalizers/references on rerun * allow passing lstsq driver * element ref unit tests * remove superfluous type * lint fix * allow setting batch_size explicitly * test applying element refs * normalizer tests * increase distributed timeout * save normalizers and linear refs in otf_fit * remove debug code * fix removing refs * swap otf_fit for fit, and save all normalizers in one file * log loading and saving normalizers * fit references and normalizer scripts * lint fixes * allow absent optim key in config * lin-ref description * read files based on extension * pass seed * rename dataset fixture * check if file is none * pass generator correctly * separate method for norms and refs * add normalizer code back * fix Generator construction * import order * log warnings if multiple inputs are passed * raise Error if duplicate references or norms are set * use len batch * assert element reference targets are scalar * fix name and rename method * load and save norms and refs using same logic * fix creating normalizer * remove print statements * adding new notebook for using fairchem models with NEBs without CatTSunami enumeration (#764) * adding new notebook for using fairchem models with NEBs * adding md tutorials * blocking code cells that arent needed or take too long * warn instead of error when duplicate norm/ref target names * allow timeout to be read from config * test seed noseed ref fits * lotsa refactoring * lotsa fixing * more fixing... * num_workers zero to prevent mp issues * add otf norms smoke test and fixes * allow overriding normalization fit values * update tests * fix normalizer loading * use rmsd instead of only stdev * fix tests * correct rmsd calc and fix loading * clean up norm loading and log values * logg linear reference metrics * load element references state dict * fix loading and tests * fix imports in scripts * fix test? * fix test * use numpy as default to fit references * minor fixes * rm torch_tempdir fixture --------- Co-authored-by: Brook Wander <[email protected]> Co-authored-by: Muhammed Shuaibi <[email protected]> Former-commit-id: 4ad6633733df9c76620ee779b6851a119e920f0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables (on the fly) fitting and estimation of normalization values and element references
Normalizers
andLinearReference
modules are trainer attributes.lin_ref
for linear references inside datasets is still enabled for backwards compatibility.TODO: