pass seed to sampler #697
Merged
pass seed to sampler #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
mshuaibii
approved these changes
May 22, 2024
levineds
pushed a commit
that referenced
this pull request
Jul 11, 2024
* pass seed to sampler * fix up tests --------- Co-authored-by: Muhammed Shuaibi <[email protected]>
misko
added a commit
that referenced
this pull request
Jan 17, 2025
* pass seed to sampler * fix up tests --------- Co-authored-by: Muhammed Shuaibi <[email protected]> Former-commit-id: 190360373648b2c07288555c49c26e7c6a396669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do not pass the seed through to our BalancedBatchSampler and a seed=0 is used by default. This changes that so the seed specified on command line is passed through to permute the order of our data.