Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate tests into a single folder #682

Merged
merged 7 commits into from
May 10, 2024
Merged

Consolidate tests into a single folder #682

merged 7 commits into from
May 10, 2024

Conversation

misko
Copy link
Collaborator

@misko misko commented May 9, 2024

This PR moves tests from various sub folders into a structure under the root tests/ folder
This is a better way to test so that pytest does not accidentally add a parent folder into syspath that then gets imported directly vs through site-packages

It is necessary to add some init.py files to overcome instances where the basename file is present more than once in the directory tree

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 41 files with indirect coverage changes

@misko misko requested a review from lbluque May 10, 2024 00:13
@misko misko marked this pull request as ready for review May 10, 2024 23:10
Copy link
Collaborator

@lbluque lbluque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @misko ftw

@lbluque lbluque self-requested a review May 10, 2024 23:17
.github/workflows/test.yml Outdated Show resolved Hide resolved
@lbluque lbluque self-requested a review May 10, 2024 23:48
Copy link
Collaborator

@lbluque lbluque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misko! We should look into enabling codecov again after this is merged

@lbluque lbluque added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit b2d28ad May 10, 2024
5 checks passed
@lbluque lbluque deleted the consolidate_tests branch May 10, 2024 23:58
levineds pushed a commit that referenced this pull request Jul 11, 2024
* add init to fix pytest

* add init to fix pytest

* fix ga workflow for test

* add pyproject toml config to pytest

* remove collect only from pytest
misko added a commit that referenced this pull request Jan 17, 2025
* add init to fix pytest

* add init to fix pytest

* fix ga workflow for test

* add pyproject toml config to pytest

* remove collect only from pytest

Former-commit-id: 8dd42ab1d1b343e4a4e5422f8be88a6093e7a779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants