Fix icon loading

[Garanas]

This branch will try to fix the icon loading procedure that was added during the 3721 patch. It is very broken from many perspectives, including:

• It loads in textures regardless of whether the mod is active.
• It loads in all ui textures, regardless of whether they're icons.

These two combined can result in strange behavior, such as inactive mods interfering with the base game. An example as reported by FtGr is the following:

These are probably defined in some mod on his system. They override the default icons on the UI.

[Garanas]

The pipeline works in terms of receiving the data at the right moment. But - no icon is rendered. Thoughts on what could be going wrong? I suspect it is the path.

You can use this mod to see the logs happening, make sure it is activated:
Penguins Icon Mod.zip

An example of how it works right now with the same unit, which is a path that starts at the folder in question (/textures/ui/something/something/strategicicons).

Downside of current approach: if the sim would use this value in the blueprint for some reason then it would desync on the spot. I do not expect this to be the case however. I have not yet checked if it desyncs the game when multiply people have different ui mods that change the icons.

[Garanas]

I think I got it working reliably now, here you have a mod to test with:

• Penguins Icon Mod.zip

I can't check if it causes a desync in multiplayer - when testing locally both instances try to read the same prefs file and it causes one to lock out the other - so the other crashes.

I need someone else to help test that.

[Garanas]

Keyser and I tested this PR tonight - it works! 🪂

[Garanas]

And a few examples on how to work with this new approach to loading icons:

• https://github.com/Garanas/strategic-icon-mod-examples

With thanks to Balthazar for the discussions and the alternative icon set for ASI.

[Garanas]

A few notes on this PR:

• Prefetching is disabled again. We can not send data to blueprints.lua reliably when prefetching is enabled.
• This PR may cause the game to crash when you have multiple instances of the game on the same computer in the same lobby, all starting at once. As the game writes the preference file on launch, blocking it for other instances.

[Dragun123]

Do I need change my icons file structure now?

[Garanas]

Not sure - if it is for a sim mod then I don't think so. If it is for a UI mod then yes, 100% certain.