Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup command line argument parsing & installation #272

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

hydrogen18
Copy link
Contributor

I had some issues with the program crashing and other problems. I made a number of changes here to address those:

  1. Install to /usr/local/bin. For programs not from the package manager on a linux machine this is the normal location.
  2. Avoid use of atof for parsing command line arguments. Use strtof instead. Check this result and if it isn't valid just terminate the program with an error. This prevents crashing the raspberry pi when an incorrect command line argument like 'bananas` is passed for the frequency arguments
  3. Normalize arguments between the two programs
  4. Use a boolean flag to check if ppm has been set. Otherwise use ntp to try and determine the correct ppm

@F5OEO F5OEO merged commit 1f8e80d into F5OEO:master Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants