Skip to content

Commit

Permalink
Pipeline Issues Fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
ramaniprateek committed Dec 13, 2024
1 parent ef58983 commit 016a5d6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion bigip/resource_bigip_ltm_datagroup.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ func resourceBigipLtmDataGroupRead(ctx context.Context, d *schema.ResourceData,
name := d.Id()
log.Printf("[DEBUG] Retrieving Data Group List %s", name)
datagroup, err := client.GetInternalDataGroup(name)
if err != nil && !strings.Contains(err.Error(), "not found") {
if err != nil && !strings.Contains(err.Error(), "not found") {
return diag.FromErr(fmt.Errorf("Error retrieving Data Group List %s: %v ", name, err))
}

Expand Down
13 changes: 6 additions & 7 deletions bigip/resource_bigip_ltm_profile_http_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func TestAccBigipLtmProfileHttpUpdateServerAgent(t *testing.T) {
CheckDestroy: testCheckHttpsDestroyed,
Steps: []resource.TestStep{
{
Config: testaccbigipltmprofilehttpDefaultConfig(TestPartition, TestHttpName, "http-profile-test"),
Config: testaccbigipltmprofilehttpDefaultConfig(TestPartition, TestHttpName),
Check: resource.ComposeTestCheckFunc(
testCheckhttpExists(TestHttpName),
resource.TestCheckResourceAttr(resFullName, "name", TestHttpName),
Expand All @@ -109,7 +109,7 @@ func TestAccBigipLtmProfileHttpUpdateServerAgent(t *testing.T) {
),
},
{
Config: testaccbigipltmprofilehttpDefaultConfig(TestPartition, TestHttpName, "http-profile-test"),
Config: testaccbigipltmprofilehttpDefaultConfig(TestPartition, TestHttpName),
Check: resource.ComposeTestCheckFunc(
testCheckhttpExists(TestHttpName),
resource.TestCheckResourceAttr(resFullName, "name", TestHttpName),
Expand All @@ -134,7 +134,7 @@ func TestAccBigipLtmProfileHttpUpdateFallbackHost(t *testing.T) {
// CheckDestroy: testCheckHttpsDestroyed,
Steps: []resource.TestStep{
{
Config: testaccbigipltmprofilehttpDefaultConfig(TestPartition, TestHttpName, "http-profile-test"),
Config: testaccbigipltmprofilehttpDefaultConfig(TestPartition, TestHttpName),
Check: resource.ComposeTestCheckFunc(
testCheckhttpExists(TestHttpName),
resource.TestCheckResourceAttr(resFullName, "name", TestHttpName),
Expand All @@ -151,7 +151,7 @@ func TestAccBigipLtmProfileHttpUpdateFallbackHost(t *testing.T) {
),
},
{
Config: testaccbigipltmprofilehttpDefaultConfig(TestPartition, TestHttpName, "http-profile-test"),
Config: testaccbigipltmprofilehttpDefaultConfig(TestPartition, TestHttpName),
Check: resource.ComposeTestCheckFunc(
testCheckhttpExists(TestHttpName),
resource.TestCheckResourceAttr(resFullName, "name", TestHttpName),
Expand All @@ -162,7 +162,6 @@ func TestAccBigipLtmProfileHttpUpdateFallbackHost(t *testing.T) {
})
}


func TestAccBigipLtmProfileHttpUpdateBasicAuthRealm(t *testing.T) {
t.Parallel()
var instName = "test-http-Update-BasicAuthRealm"
Expand Down Expand Up @@ -535,13 +534,13 @@ func testCheckHttpsDestroyed(s *terraform.State) error {
return nil
}

func testaccbigipltmprofilehttpDefaultConfig(partition, profileName, resourceName string) string {
func testaccbigipltmprofilehttpDefaultConfig(partition, profileName string) string {
return fmt.Sprintf(`
resource "bigip_ltm_profile_http" "%[3]s" {
name = "%[2]s"
defaults_from = "/%[1]s/http"
}
`, partition, profileName, resourceName)
`, partition, profileName, "http-profile-test")
}

func testaccbigipltmprofilehttpUpdateServeragentConfig(partition, profileName, resourceName string) string {
Expand Down

0 comments on commit 016a5d6

Please sign in to comment.