Icon packs don't apply #53
Comments
|
Icon pack works fine on my side. Are you running the Samsung stock ROM? |
|
Same issue for me with this crappy little: Truly an awful device, this ZTE. The launcher helps a ton over the stock offering but I can't get icons working either. Tried Frost and Lines...the latter probably incompatible. |
|
I'll definitely have a look at the issue. It seems like a few of my testers are reporting similar issues with the build — though I'm not sure if any of the recent commits have fixed the issue. |
|
Interesting, I'd love to hear what your tests come up with. And yes, I am
using the stock Samsung ROM for my S7. :)
…On Fri, Aug 16, 2019, 12:56 F4 ***@***.***> wrote:
I'll definitely have a look at the issue. It seems like a few of my
testers are reporting similar issues with the build — though I'm not sure
if any of the recent commits have fixed the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=ADUONRZS5MGBAUH5TCMEIV3QE3L2TA5CNFSM4ILBKC2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4PERVQ#issuecomment-522078422>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADUONR5KGEONREC34RGTTVDQE3L2TANCNFSM4ILBKC2A>
.
|
|
It seems that the following commit addresses the issue, but I can't confirm this as an A/B test I did shows some device still having strange issues with icon packs, This commit in question is not in any of the public releases of the launcher. However, if it's possible, I may try pushing a test build — should anyone be available to test it, of course. |
|
I am willing to test it. I can d/l and build this if you don't get a test build up soon (let me know if that is easier for you). |
|
I'd also be willing to test it, and if you'd be interested, I have a Jenkins instance that i could set the project up on so you could have live dev builds. If you're interested, I'd just need build instructions and I could get it all set up. But in the meantime, if you happen to get a test build out, I'd be happy to try it! |
|
Attached here is a test release. It's built with my sign key, therefore F-Droid release will be incompatible with it — I advise a backup before trying the build out. The test release should have all of the present changes of the launcher (up until the time of this writing); this should also include the commit I linked before. |
|
Awesome, thanks! Tested and confirmed with both Frost and Delta icons -- it
works fine now.
…On Mon, Aug 19, 2019, 13:06 F4 ***@***.***> wrote:
app-release.zip
<https://github.com/F4uzan/HgLauncher/files/3516876/app-release.zip>
Attached here is a test release. It's built with my sign key, therefore
F-Droid release will be incompatible with it — I advise a backup before
trying the build out.
The test release should have all of the present changes of the launcher
(up until the time of this writing); this should also include the commit I
linked before.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#53?email_source=notifications&email_token=ADUONR54WIDIBBCVHTW3NJTQFLHIPA5CNFSM4ILBKC2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4TUMJA#issuecomment-522667556>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADUONR34UTZFKZHRZMDZ3NLQFLHIPANCNFSM4ILBKC2A>
.
|
|
I'll chalk it up as the commit fixing the issue well. I'll keep this open until v1.4.3 is up though, so do notify me in case more related issues come through. |
|
Closing as this has been solved with v1.4.2.3. |
What's the issue?
I cannot use any icon packs with HgLauncher.
To reproduce…
Steps to reproduce the behaviour:
Expected behaviour
The icon pack applies and shows in the app list.
What did you see instead?
It reverts to the default icon set.
Screenshots
Not much to show, it lists the packs as available but selecting the icon pack doesn't persist.
Device information (please complete the following information):
The text was updated successfully, but these errors were encountered: