Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: device handling & user settings #258

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: device handling & user settings #258

merged 1 commit into from
Jan 9, 2025

Conversation

LucasMaupin
Copy link
Contributor

No description provided.

malmen237
malmen237 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@malmen237 malmen237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Saelmala
Saelmala reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a problem if the user has a long username:
image

@LucasMaupin LucasMaupin merged commit 8c807be into development Jan 9, 2025
2 checks passed
@LucasMaupin LucasMaupin deleted the improvement/devices branch January 9, 2025 09:11
martinstark pushed a commit that referenced this pull request Jan 28, 2025
@LucasMaupin @martinstark
feat: device handling & user settings (#258)
4e8c0e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saelmala Saelmala Saelmala left review comments

@malmen237 malmen237 malmen237 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasMaupin @Saelmala @malmen237