Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialog cleanup after dialplan callback finshed #92

Open
vodik opened this issue Mar 30, 2018 · 1 comment
Open

Add dialog cleanup after dialplan callback finshed #92

vodik opened this issue Mar 30, 2018 · 1 comment

Comments

@vodik
Copy link
Contributor

vodik commented Mar 30, 2018

I need to do a bit more research into how this should be implemented to be SIP compliant, but something sensible needs to happen to inbound traffic on a dialog after the server has stopped processing traffic on that dialog.

Currently the traffic is ignored (its queued, but the queue is not being read from anymore).

One of two things could happen, not sure which one makes sense (leaning on 2)

  1. Reject the traffic with some sort of error message.
  2. Call the dialplan handler again, and do something to make it re-entrant, so the server can pick up where is stopped.
ovv added a commit that referenced this issue Apr 26, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
ovv added a commit that referenced this issue Apr 26, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
@ovv
Copy link
Contributor

ovv commented Apr 26, 2018

With #113 the application completely discard the dialplan once they are closed so inbound traffic on an old dialog goes through the Dialplan again and it is recreated.

ovv added a commit that referenced this issue Apr 26, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
ovv added a commit that referenced this issue Apr 26, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
ovv added a commit that referenced this issue Apr 27, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants