Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some SIP scenarios cause incorrect traffic to trigger on Dialog.close #87

Open
vodik opened this issue Mar 20, 2018 · 2 comments
Open

Some SIP scenarios cause incorrect traffic to trigger on Dialog.close #87

vodik opened this issue Mar 20, 2018 · 2 comments

Comments

@vodik
Copy link
Contributor

vodik commented Mar 20, 2018

Couple issues here related to having very primitive support of server side dialog and not bookkeeping dialog state completely correctly.

  • Server side closes inbound SUBSCRIBE/REGISTER messages by ending the client a SUBSCRIBE/REGISTER message with Expires: 0
  • Server side handling of INVITEs don't close with a BYE, but with a INVITE message with an Expires: 0
ovv added a commit that referenced this issue Apr 19, 2018
@ovv
Set dialog as inbound when created in run_dialplan
ed49ff7 
I'm not sure this is the right fix but looks like
it handle #87 for now
@ovv ovv mentioned this issue Apr 19, 2018
Merged
@ovv ovv closed this as completed Apr 20, 2018
@ovv ovv reopened this Apr 20, 2018
@ovv
Copy link
Contributor

ovv commented Apr 20, 2018

I haven't tested the INVITE bug

@vodik
Copy link
Contributor Author

vodik commented Apr 20, 2018

I'll give it a go today when I deploy the new dialplan stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vodik @ovv