Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

297 visits stop-gap bugfix #298

Merged
merged 6 commits into from
Nov 15, 2023
Merged

297 visits stop-gap bugfix #298

merged 6 commits into from
Nov 15, 2023

Conversation

hyi
Copy link
Collaborator

@hyi hyi commented Nov 13, 2023

@maximusunc This PR fixes the issue #297 and has been deployed to all ICEES+ instances for now before we update FHIR PIT and rerun FHIR PIT to generate new data. After FHIR PIT is updated and new data is regenerated, I'll need to create another small PR to remove a condition check in get_operator_and_value() function which is covered in detail in the comment there. Since I am not sure when we can finish FHIR PIT and data update and the condition check to be removed for the stop-gap solution is a small code change, I am creating this PR now to get this merged so the code is in sync with latest deployment.

@hyi hyi requested a review from maximusunc November 13, 2023 20:15
@hyi hyi merged commit ef94115 into master Nov 15, 2023
@hyi hyi deleted the 297-visits-bugfix branch November 15, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants