Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multivariate endpoint issue when using year as input parameter for filtering and for multivariate feature request #289

Closed
karafecho opened this issue Oct 13, 2023 · 1 comment
Assignees

Comments

@karafecho
Copy link
Contributor

This issue is to report an issue with the multivariate endpoint. Specifically, when a user selects year as an input parameter for filtering AND as a multivariate feature in their request, the results that are returned are correct but confusing, in that all years will be returned in the multivariate output but they will be empty apart from the year that was used for filtering.

Here's an example:


curl -X 'POST' \
  'https://icees-pcd.renci.org/cohort/COHORT%3A1/multivariate_feature_analysis' \
  -H 'accept: text/tabular' \
  -H 'Content-Type: application/json' \
  -d '[
  "TotalEDInpatientVisits",
  "year",
  "PrednisoneRx"
]'
+--------------------------+--------+----------------+-------------+
| TotalEDInpatientVisits   | year   | PrednisoneRx   |   frequency |
+==========================+========+================+=============+
| = 0                      | = 2010 | = 0            |        1311 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2010 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2011 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2011 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2012 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2012 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2013 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2013 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2014 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2014 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2015 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2015 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2016 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2016 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2017 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2017 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2018 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2018 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2019 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2019 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2020 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2020 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2021 | = 0            |           0 |
+--------------------------+--------+----------------+-------------+
| = 0                      | = 2021 | = 1            |           0 |
+--------------------------+--------+----------------+-------------+
hyi added a commit that referenced this issue Oct 18, 2023
hyi added a commit that referenced this issue Oct 19, 2023
…iate analysis endpoint (#293)

* fixed issue #289

* make multivariate analysis endpoint to honor cohorts
@karafecho
Copy link
Contributor Author

Closing this ticket, as the issue was resolved ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants