Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimisation, #3] updated various dependencies #4

Merged

Conversation

davesag
Copy link
Contributor

@davesag davesag commented Feb 2, 2018

I have updated the following

Fixed any issues identified by standard, and fixed a small test failure.

I did not upgrade simple-get however as doing so caused test failures I could not figure out.

Copy link
Member

@jmckinnell jmckinnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this.

@jmckinnell jmckinnell merged commit 2805b87 into Experience-Monks:master Feb 2, 2018
@davesag davesag deleted the feature/3/update-dependencies branch February 3, 2018 03:17
@davesag
Copy link
Contributor Author

davesag commented Feb 3, 2018

Thanks. please let me know when you republish the updated version so I can notify various upstream projects.

@mattdesl
Copy link
Contributor

mattdesl commented Feb 3, 2018

Thanks, I published a new minor version, tried to clean up some of the tests and also updated simple-get to latest version.

If anybody has a suggestion on a way to automate all the tests in node and browser with CI, feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update buffer-to-arraybuffer dependency
3 participants