Fix EPSILON #11
Merged
Fix EPSILON #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The title of #10 should have read "EPSILON way too small". Suggesting `Number.EPSILON` was a mistake as it relates to doubles and is far too small. e335c74 broke pitching a `perspective-camera` all the way "up" or "down" using an `orbit-controls`. This is due to routines like gl-mat4/invert failing to behave when backed by `Float32Array`s which I demonstrate in #5 See https://en.wikipedia.org/wiki/Machine_epsilon for formulaic explanations. For the record: `gl-matrix` uses `0.000001` which you'll agree is more than close enough. I apologise for any confusion as well as my mistaken suggestion. This change should also alleviate many instances of #5 ^w^
|
Thanks @pyrotechnick for digging! Would you like to be a contributor to this module as well? |
|
If you flip my commit bit I can fix my own mistakes! |
|
This is merged + patched in v1.0.4 |
|
You're now a contributor. 😄 Guidelines: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title of #10 should have read "EPSILON way too small".
Suggesting
Number.EPSILONwas a mistake as it relates to doubles and is far too small.e335c74 broke pitching a
perspective-cameraall the way "up" or "down" using anorbit-controls.This is due to routines like gl-mat4/invert failing to behave when backed by
Float32Arrays which I demonstrate in #5See https://en.wikipedia.org/wiki/Machine_epsilon for formulaic explanations.
For the record:
gl-matrixuses0.000001which you'll agree is more than close enough.I apologise for any confusion as well as my mistaken suggestion.
This change should also alleviate many instances of #5 ^w^