feat: bump node version to 18.17.1

[pac-guerreiro]

Details

Onyx currently enforces developers to use NodeJS 16.15.1. As of September, NodeJS 16.x will reach its End-of-life (EOL), meaning there will be no more updates, patches, or security fixes. Additionally, reactwg/react-native-releases#64.

Using an outdated version of NodeJS not only exposes the application to potential security vulnerabilities, compatibility issues, and prevents developers from leveraging the latest features, optimizations, and improvements available in newer versions of NodeJS.

Related Issues

• [HOLD for payment 2023-11-29] Bump E/App and Onyx to use NodeJS 20.9.0 LTS App#25824

Automated Tests

Not necessary since this PR only changes project configuration files.

Linked PRs

None.

[bondydaa]

👍 seems right to me but going to assign some others who are more familiar as well.

[roryabraham]

I think this should be subject to the merge freeze, putting it on HOLD. @pac-guerreiro please take this off HOLD when the merge freeze is lifted

[bondydaa]

👍 again, i think feature freeze is over so taking off hold but @roryabraham you want to double check this and merge if you feel 👍 about it?

[roryabraham]

LGTM as long as we follow-up to remove the range and pin to 18

[roryabraham]

However, I can't merge this PR due to it containing unsigned commits. @pac-guerreiro, please set up GPG signing for your commits and register your GPG key with GitHub, then rebase this PR, reword each commit, and force-push.

[roryabraham]

Tests are failing

[parasharrajat]

So react-native-performance was upgraded to v5.x recently #340. Can that be related to test failure?

[fabioh8010]

Just a reminder that @pac-guerreiro is OOO at the moment and will return on 20/09.

[pac-guerreiro]

@roryabraham

This test is failing but it's unrelated to my changes:

[roryabraham]

@pac-guerreiro tests appear to be passing on main, please try merging main into this branch?

[pac-guerreiro]

@roryabraham

I just rebased the branch with main but the issue persists, although locally the tests are passing. Maybe this is a cache issue? Could you re-run the workflow and maybe delete the cache?

[roryabraham]

Deleted caches and re-running

[pac-guerreiro]

@roryabraham

I think I might have found why tests are failing:

It seems that we're using an old version of actions/setup-node@v1 and I'm trying to use a feature to read the node version from a config file which is only available in actions/setup-node@v3

[AndrewGable]

Can you update it in this PR and see if the tests pass?

[roryabraham]

For setup-node feel free to pin it directly to the @V3 tag instead of a commit hash

[pac-guerreiro]

@roryabraham I'm having issues with GPG. Somehow I'm unable to commit anything, even after generating a new key 😢

Solved!

[pac-guerreiro]

@AndrewGable @roryabraham All checks have passed! 😄

[bondydaa]

going to merge this so it doesn't get tripped up by some other conflict, looks like rory had previously approved it but we didn't merge b/c of failing tests that are now fixed.