Add support for inline image #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
commented
Mar 29, 2024
tomekzaw
commented
Mar 29, 2024
tomekzaw
commented
Apr 8, 2024
parser/__tests__/index.test.js
Outdated
| }); | ||
|
|
||
| test('blockquote in alt', () => { | ||
| // TODO: this test is failing !!! |
There was a problem hiding this comment.
Should we mark it as "xfail" or just fix it?
There was a problem hiding this comment.
Actually this comment should be removed, test is already fixed
Co-authored-by: Tomek Zawadzki <[email protected]>
|
It seems like there's some problem with the following input: 
|
tomekzaw
commented
Apr 9, 2024
Co-authored-by: Tomek Zawadzki <[email protected]>
robertKozik
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds support for inline images inserted with the following syntax:
.Related Issues
Expensify/App#39275
Manual Tests
Linked PRs