Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the blockquote parsing logic for messages and rawInput #820

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Skalakid
Copy link
Contributor

@Skalakid Skalakid commented Nov 18, 2024

This PR changes and unifies the blockquote parsing logic for the NewDot messages and the Live Markdown Input. Currently, the parsing result is different when the shouldKeepRawInput variable is true. Thanks to the changes in this PR, the results are consistent (visually). The only difference is that the tags are being grouped when shouldKeepRawInput=false.

Example:

> test
>> test
> test

NewDot sent message shouldKeepRawInput=false

<blockquote>test<br /><blockquote>test</blockquote>test</blockquote>

Live Markdown Input shouldKeepRawInput=true

<blockquote> test</blockquote>
<blockquote><blockquote> test</blockquote></blockquote>
<blockquote> test</blockquote>

Fixed Issues

$ Expensify/App#45154
$ Expensify/App#47951

Tests

  1. Applying changes to both the NewDot app and the Live Markdown Input
  2. Verify if the markdown is the same when writing the message and after sending it

QA

Same as Tests

@Skalakid Skalakid force-pushed the @Skalakid/fix-blockquote-formatting branch from 17c5562 to a1511ab Compare November 22, 2024 16:51
@Skalakid Skalakid marked this pull request as ready for review November 27, 2024 08:42
@pecanoro pecanoro self-requested a review November 27, 2024 15:27
@Pujan92
Copy link
Contributor

Pujan92 commented Nov 28, 2024

commenting for the assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants