-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow indented text in quotes #673
Conversation
@s77rt I want to confirm the expected behavior:
1️⃣ or 2️⃣? |
@tienifr I don't have a strong preference, as long as we have consistency it should be good enough. Perhaps 2️⃣ is a better fit here |
@tienifr Any progress on this? |
@s77rt I forgot about the case where there're trailing spaces at the end of the whole quote. If we follow 2️⃣ above, we can opt in to keep (1) or trim (2) these spaces. For example:
Output can either be (1) or (2) I have solutions for both but (2) will add one more conditional statements. |
After all, I think this is the best option 😄 We can avoid increased code complexity, maintain consistency but still achieve the expected behavior. Current implementation also trim trailing spaces. |
Co-authored-by: Abdelhafidh Belalia <[email protected]>
Co-authored-by: Abdelhafidh Belalia <[email protected]>
So we still keep both trailing and leading spaces, right? |
@s77rt from your conversation above this sounds the best option. Can you please confirm so we can finish up this PR. Thanks |
Yes, we won't alter user input on quotes |
cc @Julesssss |
Testing to occur when the |
This PR enables indented text to show as is (do not trim the spaces) in quotes.
Fixed Issues
$ Expensify/App#38156
Tests
1. What unit/integration tests cover your change? What autoQA tests cover your change?
The
ExpensiMark-HTML-test.js
is updated to include the new test cases and modify existing tests to match with new expected behaviors.2. What tests did you perform that validates your changed worked?
Indented 4
line shows with 4-space indentation in quoteQA
1. What does QA need to do to validate your changes?
Test in Expensify App follow these steps:
Indented 4
line shows with 4-space indentation in quote2. What areas to they need to test for regressions?
Screenshots
Screen.Recording.2024-03-29.at.02.13.47-compressed.mov