Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 1 vulnerabilities #609

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

MelvinBot
Copy link

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

As this is a private repository, Snyk-bot does not have access. Therefore, this PR has been created automatically, but appears to have been created by a real user.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 661/1000
Why? Recently disclosed, Has a fix available, CVSS 7.5
Missing Release of Resource after Effective Lifetime
SNYK-JS-INFLIGHT-6095116
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@MelvinBot MelvinBot requested a review from a team as a code owner November 30, 2023 14:49
@melvin-bot melvin-bot bot requested review from MariaHCD and removed request for a team November 30, 2023 14:50
MariaHCD
MariaHCD previously approved these changes Dec 11, 2023
Copy link
Contributor

@MariaHCD MariaHCD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me considering it's only updating grunt and jest.

Tests are continuing to pass as expected:

expensify-common git:(snyk-fix-cb4f3e1b76d6d8793e32d09ac342fad8) ✗ npm run test

> [email protected] test
> jest

 PASS  __tests__/Logger-test.js
 PASS  __tests__/URL-test.js
 PASS  __tests__/ExpensiMark-HTMLToText-test.js
 PASS  __tests__/Str-test.js
 PASS  __tests__/ExpensiMark-Markdown-test.js
 PASS  __tests__/ExpensiMark-test.js
 PASS  __tests__/ExpensiMark-HTML-test.js

Test Suites: 7 passed, 7 total
Tests:       224 passed, 224 total
Snapshots:   0 total
Time:        1.162 s, estimated 2 s
Ran all test suites.

@MariaHCD MariaHCD merged commit 8fea311 into main Dec 11, 2023
5 checks passed
@MariaHCD MariaHCD deleted the snyk-fix-cb4f3e1b76d6d8793e32d09ac342fad8 branch December 11, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants