Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate value in "Name on card" field #6845

Merged
merged 6 commits into from
Dec 22, 2021
Merged

Conversation

marcochavezf
Copy link
Contributor

Details

This PR prevents entering only numbers in the field Name on card. Also, limits the number of characters in expiration date and CVV fields.

Fixed Issues

$ #6689

Tests / QA

  1. Go to Setting -> Payments -> Add payment method -> Debit Card
  2. Insert only numbers in the Name on Card field and click submit. Verify that an error message is displayed in that field.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Screen Shot 2021-12-20 at 17 03 51

@marcochavezf marcochavezf self-assigned this Dec 20, 2021
@marcochavezf marcochavezf requested a review from a team as a code owner December 20, 2021 23:27
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team December 20, 2021 23:27
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well so far, added a few comments.

@Julesssss Julesssss merged commit abcf614 into main Dec 22, 2021
@Julesssss Julesssss deleted the marco-validateCardName branch December 22, 2021 14:08
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.23-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants