Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html formatted comments #64

Merged
merged 4 commits into from
Aug 11, 2020
Merged

Add html formatted comments #64

merged 4 commits into from
Aug 11, 2020

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Aug 11, 2020

Fixes #53

This only adds support for web, and hopefully shouldn't break mobile. I tried looking into using https://github.com/react-native-community/react-native-webview but that was definitely NOT the way to go for web. Maybe it will work for mobile? The downside seems to be you can't have variable height content.

@tgolen tgolen requested a review from AndrewGable August 11, 2020 21:29
@tgolen tgolen self-assigned this Aug 11, 2020
@AndrewGable AndrewGable merged commit 8c0e5eb into master Aug 11, 2020
@roryabraham roryabraham deleted the tgolen-html-comments branch November 2, 2022 23:06
mountiny pushed a commit that referenced this pull request Apr 4, 2024
* Implement progress bar

* Render progressBar with precedence of header

* Story for progressBar

* Missing semicolons

* Drop shouldShowProgressBar

* Fix double header rendered

* Wrap around useMemo

---------

Co-authored-by: Mateusz Rajski <[email protected]>
Copy link

cloudflare-workers-and-pages bot commented Sep 9, 2024

Deploying helpdot with  Cloudflare Pages  Cloudflare Pages

Latest commit: 14a38ec
Status: ✅  Deploy successful!
Preview URL: https://e7b6913c.helpdot.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to implement HTML rendered comments so we get styling
2 participants