-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crashlytics to Chat #582
Conversation
This comment has been minimized.
This comment has been minimized.
Ok, I messed around with this a bit more and I got the crash showing up on the dashboard. Going to update this PR w/ the working config and then test/confirm that is what works tomorrow. |
This comment has been minimized.
This comment has been minimized.
Got Android working (thanks to @timszot for helping me test) and to the point where only Release builds are producing crashes on the dashboard. Will clean this up next week and get it in review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Going to run through the tests this afternoon.
Ah, forgot to mention that there are some conflicts, most likely due to mis-matched versions in the build.gradle. |
Ran into some dev environment problems, but I got through the first few steps of the tests now. Tomorrow morning I'll test the release builds portion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@timszot @AndrewGable will you please review this?
This PR adds Crashlytics to Chat so that we can get reports of crashes that users are experiencing as they happen. This is configured to only report crashes for release builds, dev builds will not report crashes. This PR also updates the fastlane file on iOS to upload the dsym from the build output to crashlytics automatically.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/142274
Tests
npm install
andcd ios && pod install
to confirm all the dependencies are up to datenpm run ios
/npm run android
(debug builds) and confirm that the apps build finesubmitForm
inReportActionCompose.js
to doabc.test();
at the beginning of the function.~/Library/Developer/Xcode/DerivedData/ReactNativeChat-bkiuyhfpclvjiabklrsfbkppdtbh/Build/Products/Release-iphonesimulator/
(replace your simluator name) and delete theChat.app.dSYM
file if it exists. This will allow us to overwrite it on the next build, so we can upload it to Firebasereact-native run-android --variant=release
Debug Executable
, then run the build normally to a simulator.ReactNativeChat
, be sure to update your simulator name (afterDerivedData
)