-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manager mctest tooltips to create expense flow #57480
base: main
Are you sure you want to change the base?
Add manager mctest tooltips to create expense flow #57480
Conversation
…to add-manager-mctest-tooltips-to-create-expense-flow
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@DylanDylann FYI I used @nkdengineer proposed solution for fixing issue which cause the deploy blocker. |
Also @shawnborton could you take a look here I think I fixed issues which you mentioned here #57171 (comment) |
Sure! But I'm not seeing any screenshots here... where is the best place to find them? |
Explanation of Change
Fixed Issues
$ #55008
$ #55009
PROPOSAL:
Tests
Make sure you are added to beta for testing manager mctest
And you are on account that didn't send any expenses or dont have in Onyx
scanTestTooltip
value inNVP_DISMISSED_PRODUCT_TRAINING
keyOpen FAB
Select Create Expense
When on Scan tab verify that tooltip for trying out testing receipt is visible
Add some file and go to next step
Go to select participant page
Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
Select Manager McTest
On confirmation page verify that the tooltip above confirm button is visible
Open FAB
Select Create Expense
Select Manual
Add some amount
Go to select participant page
Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
Select Manager McTest
On confirmation page verify that the tooltip above confirm button is visible
Open FAB
Select Create Expense
Select Distance
Add some waypoints
Go to select participant page
Verify that Manager McTest is visible and tooltip for selecting it for testing is visible
Select Manager McTest
On confirmation page verify that the tooltip above confirm button is visible
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop