fix: pre-validate masked input #56462

kirillzyusko · 2025-02-06T12:54:58Z

Explanation of Change

Added regexp validation before applying a mask.

Fixed Issues

$ #56330
PROPOSAL: N/A

Tests

Go Reports > click on Filter > click on Total
Enter few digits > press dot key or comma key to enter a decimal point
Enter two digits after the decimal point
Move the cell pointer on the left side of the entered decimal point (dot)
Press dot key

Offline tests

N/A

QA Steps

Go Reports > click on Filter > click on Total
Enter few digits > press dot key or comma key to enter a decimal point
Enter two digits after the decimal point
Move the cell pointer on the left side of the entered decimal point (dot)
Press dot key

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-12.at.10.47.07.mov

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-12.at.11.14.34.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-12.at.10.58.00.mp4

MacOS: Chrome / Safari

masked-input-1.3-demo.mov

MacOS: Desktop

masked-input-1.3-demo.mov

melvin-bot · 2025-02-06T12:55:03Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

kirillzyusko · 2025-02-06T12:57:27Z

@brunovjk would you mind to test these changes? As a reference I took existing web input behavior and tried to match that on all platforms 👀

I also update advanced-input-mask library, so you'll need to re-install dependencies

brunovjk · 2025-02-06T13:43:05Z

Great work @kirillzyusko it's much better now, but I can't leave the field blank, without any digits:

Screen.Recording.2025-02-06.at.10.39.42.mov

kirillzyusko · 2025-02-06T13:52:58Z

@brunovjk yep, can reproduce it! Fixed in 639e0bc

brunovjk · 2025-02-06T15:22:58Z

Very good @kirillzyusko

Android: Native

56462_android_native.mov

iOS: Native

56462_ios_native.mov

sorry for the inconvenience, but there is a detail that is bothering me, on the web (I was able to reproduce it with less reliability in native as well), when typing a letter, the "cursor" moves:

Screen.Recording.2025-02-06.at.12.17.02.mov

What do you think? Thank you.

kirillzyusko · 2025-02-06T15:51:41Z

sorry for the inconvenience, but there is a detail that is bothering me, on the web, when typing a letter, the "cursor" moves

What is the expected behavior? To move cursor to the end (as it is in current web implementation)?

brunovjk · 2025-02-06T15:53:39Z

sorry for the inconvenience, but there is a detail that is bothering me, on the web, when typing a letter, the "cursor" moves

What is the expected behavior? To move cursor to the end (as it is in current web implementation)?

When typing letters, I believe nothing should happen. We can confirm with luacmartins

kirillzyusko · 2025-02-06T17:56:41Z

When typing letters, I believe nothing should happen. We can confirm with luacmartins

I think on web it always go to the end in case if invalid character has been typed (i. e. including letters) 🤔

brunovjk · 2025-02-06T18:03:45Z

Great! I'll finish the tests and checklist later, but everything looks good so far.

brunovjk · 2025-02-06T20:24:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

56462_android_native.mov

Android: mWeb Chrome

56462_android_web.mov

iOS: Native

56462_ios_native.mov

iOS: mWeb Safari

56462_ios_web.mov

MacOS: Chrome / Safari

56462_web_chrome.mov

MacOS: Desktop

56462_web_desktop.mov

brunovjk

Everything looks fine to me, please just pay attention to these comments comment_1 comment_2. @kirillzyusko could you please complete your checklist? Thanks a lot.

luacmartins · 2025-02-10T23:44:30Z

@kirillzyusko what's left to make this PR ready for review?

melvin-bot · 2025-02-12T10:15:37Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kirillzyusko · 2025-02-12T10:16:29Z

@brunovjk I fixed a problem with moving cursor - now cursor will stay in the same position (on all platforms) if incorrect symbol has been types.

@brunovjk @luacmartins this PR is ready for review now (I mean I completed checklist/uploaded videos) 👀

brunovjk · 2025-02-12T14:23:05Z

In native everything is very good now, it seems more solid to me, congratulations @kirillzyusko. However, in web I found a bug.
The field value is deleted when we start typing a new one, in native it works fine, as nothing happens:

Screen.Recording.2025-02-12.at.11.17.54.mov

Can you reproduce it? Thank you.

kirillzyusko · 2025-02-12T18:24:14Z

@brunovjk I'll check! 👀

kirillzyusko · 2025-02-17T13:22:39Z

Just a small update - I found a problem. Will fix it today/tomorrow 🤞

kirillzyusko · 2025-02-17T14:36:35Z

@brunovjk may I ask you to test this PR again (I hope it will be the last time 😅)?

brunovjk · 2025-02-18T12:00:38Z

@brunovjk may I ask you to test this PR again (I hope it will be the last time 😅)?

Sorry, I missed your message. I'll review it today 🚀 🚀 🚀

brunovjk

Looking good to me 🚀 Thank you very much for your effort @kirillzyusko.

Screenshots/Videos

Android: Native

56462_android_native.mov

Android: mWeb Chrome

56462_android_web.mov

iOS: Native

56462_ios_native.mov

iOS: mWeb Safari

56462_ios_web.mov

MacOS: Chrome / Safari

56462_web_chrome.mov

MacOS: Desktop

56462_web_desktop.mov

brunovjk · 2025-02-18T15:23:51Z

All yours @luacmartins :D

kirillzyusko · 2025-02-18T15:32:06Z

Looking good to me 🚀 Thank you very much for your effort

Thank you for careful reviewing 😊 ❤️

luacmartins · 2025-02-18T19:46:00Z

Verify HybridApp build is failing with:

 gh pr comment https://github.com/Expensify/App/pull/56462 --body \
  ":warning: This PR is possibly changing native code, it may cause problems with HybridApp. Please run an AdHoc build to verify that HybridApp will not break. :warning:"
  shell: /usr/bin/bash -e {0}
  env:
    GITHUB_TOKEN: ***
GraphQL: Resource not accessible by integration (addComment)

NAB

melvin-bot · 2025-02-18T19:46:12Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2025-02-18T19:46:24Z

See comment above

OSBotify · 2025-02-18T19:56:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-19T03:41:13Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-20T02:48:50Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.1-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

kirillzyusko added 2 commits February 6, 2025 13:52

fix: pre-validate maked input

ce55b69

fix: jsdoc

cd99f3e

This comment was marked as outdated.

Sign in to view

fix: allow empty string

639e0bc

brunovjk approved these changes Feb 6, 2025

View reviewed changes

melvin-bot bot requested a review from luacmartins February 6, 2025 20:29

fix: use latest advanced input mask version

1f3548b

kirillzyusko marked this pull request as ready for review February 12, 2025 10:15

kirillzyusko requested a review from a team as a code owner February 12, 2025 10:15

melvin-bot bot requested review from brunovjk and removed request for a team February 12, 2025 10:15

fix: incorrect symbol causes default value to disappear

1e123d2

brunovjk approved these changes Feb 18, 2025

View reviewed changes

luacmartins approved these changes Feb 18, 2025

View reviewed changes

luacmartins merged commit 01242a7 into Expensify:main Feb 18, 2025
21 of 22 checks passed

melvin-bot bot added the Emergency label Feb 18, 2025

luacmartins removed the Emergency label Feb 18, 2025

github-actions bot mentioned this pull request Feb 19, 2025

Deploy Checklist: New Expensify 2025-02-19 #57066

Closed

56 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: pre-validate masked input #56462

fix: pre-validate masked input #56462

kirillzyusko commented Feb 6, 2025 •

edited

Loading

melvin-bot bot commented Feb 6, 2025

kirillzyusko commented Feb 6, 2025

This comment was marked as outdated.

brunovjk commented Feb 6, 2025

kirillzyusko commented Feb 6, 2025

brunovjk commented Feb 6, 2025 •

edited

Loading

kirillzyusko commented Feb 6, 2025

brunovjk commented Feb 6, 2025

kirillzyusko commented Feb 6, 2025

brunovjk commented Feb 6, 2025

brunovjk commented Feb 6, 2025

brunovjk left a comment

luacmartins commented Feb 10, 2025

melvin-bot bot commented Feb 12, 2025

kirillzyusko commented Feb 12, 2025 •

edited

Loading

brunovjk commented Feb 12, 2025

kirillzyusko commented Feb 12, 2025

kirillzyusko commented Feb 17, 2025

kirillzyusko commented Feb 17, 2025

brunovjk commented Feb 18, 2025

brunovjk left a comment

brunovjk commented Feb 18, 2025

kirillzyusko commented Feb 18, 2025

luacmartins commented Feb 18, 2025

melvin-bot bot commented Feb 18, 2025

luacmartins commented Feb 18, 2025

OSBotify commented Feb 18, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 20, 2025

fix: pre-validate masked input #56462

fix: pre-validate masked input #56462

Conversation

kirillzyusko commented Feb 6, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 6, 2025

kirillzyusko commented Feb 6, 2025

This comment was marked as outdated.

brunovjk commented Feb 6, 2025

kirillzyusko commented Feb 6, 2025

brunovjk commented Feb 6, 2025 • edited Loading

kirillzyusko commented Feb 6, 2025

brunovjk commented Feb 6, 2025

kirillzyusko commented Feb 6, 2025

brunovjk commented Feb 6, 2025

brunovjk commented Feb 6, 2025

Reviewer Checklist

Screenshots/Videos

brunovjk left a comment

Choose a reason for hiding this comment

luacmartins commented Feb 10, 2025

melvin-bot bot commented Feb 12, 2025

kirillzyusko commented Feb 12, 2025 • edited Loading

brunovjk commented Feb 12, 2025

kirillzyusko commented Feb 12, 2025

kirillzyusko commented Feb 17, 2025

kirillzyusko commented Feb 17, 2025

brunovjk commented Feb 18, 2025

brunovjk left a comment

Choose a reason for hiding this comment

Screenshots/Videos

brunovjk commented Feb 18, 2025

kirillzyusko commented Feb 18, 2025

luacmartins commented Feb 18, 2025

melvin-bot bot commented Feb 18, 2025

luacmartins commented Feb 18, 2025

OSBotify commented Feb 18, 2025

github-actions bot commented Feb 19, 2025

github-actions bot commented Feb 20, 2025

kirillzyusko commented Feb 6, 2025 •

edited

Loading

brunovjk commented Feb 6, 2025 •

edited

Loading

kirillzyusko commented Feb 12, 2025 •

edited

Loading