Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Use POST for SAML login" #55432

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[CP Staging] Revert "Use POST for SAML login" #55432

merged 1 commit into from
Jan 20, 2025

Conversation

NikkiWines
Copy link
Contributor

@NikkiWines NikkiWines commented Jan 17, 2025 •
edited
Loading

Reverts #52658

See: #52658 (comment)

@NikkiWines NikkiWines self-assigned this Jan 17, 2025
@NikkiWines NikkiWines requested a review from a team as a code owner January 17, 2025 19:49
@NikkiWines NikkiWines mentioned this pull request Jan 17, 2025
Merged
49 tasks
@melvin-bot melvin-bot bot requested a review from MarioExpensify January 17, 2025 19:50
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 17, 2025

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 17, 2025 19:50
@NikkiWines
Copy link
Contributor Author

Merging this and asking for a CP

@NikkiWines NikkiWines merged commit ecb1e51 into main Jan 20, 2025
13 of 17 checks passed
@NikkiWines NikkiWines deleted the revert-52658-nikki-saml-use-post branch January 20, 2025 17:01
@NikkiWines NikkiWines changed the title Revert "Use POST for SAML login" [CP Staging] Revert "Use POST for SAML login" Jan 20, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 20, 2025

@NikkiWines looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Jan 20, 2025
@NikkiWines
Copy link
Contributor Author

Straight revert, no checklist needed and ESLint failure was tied to code that was unchanged in this PR

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jan 20, 2025
@NikkiWines @OSBotify
Merge pull request #55432 from Expensify/revert-52658-nikki-saml-use-…
b00cd6b 
…post

Revert "Use POST for SAML login"

(cherry picked from commit ecb1e51)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 20, 2025
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
Closed
60 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.87-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioExpensify MarioExpensify MarioExpensify approved these changes

Assignees

@NikkiWines NikkiWines

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikkiWines @OSBotify @MarioExpensify