Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "fix confirmation button jump" #55296

Merged
merged 2 commits into from
Jan 16, 2025
Merged

[CP Staging] Revert "fix confirmation button jump" #55296

merged 2 commits into from
Jan 16, 2025

Conversation

shubham1206agra
Copy link
Contributor

@shubham1206agra shubham1206agra commented Jan 15, 2025 •
edited
Loading

Reverts #54736

$ #55275

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 15, 2025

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@shubham1206agra shubham1206agra mentioned this pull request Jan 15, 2025
Closed
8 tasks
@shubham1206agra shubham1206agra marked this pull request as ready for review January 15, 2025 17:46
@shubham1206agra shubham1206agra requested a review from a team as a code owner January 15, 2025 17:46
@melvin-bot melvin-bot bot requested a review from mjasikowski January 15, 2025 17:46
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 15, 2025

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 15, 2025 17:46
@mjasikowski
Copy link
Contributor

The tests are failing here, but it looks like a straight revert. @mountiny let me know what to do with this, as I see you were involved in the original issue.

mjasikowski
mjasikowski approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@mjasikowski mjasikowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mjasikowski mjasikowski merged commit 71501b9 into Expensify:main Jan 16, 2025
13 of 16 checks passed
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jan 16, 2025

@mjasikowski looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Jan 16, 2025
@mjasikowski
Copy link
Contributor

Not an emergency, tests were not passing due to eslint changes between releases, but otherwise it's a straight revert.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mountiny mountiny changed the title Revert "fix confirmation button jump" [CP Staging] Revert "fix confirmation button jump" Jan 16, 2025
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 16, 2025
OSBotify pushed a commit that referenced this pull request Jan 16, 2025
@mjasikowski @OSBotify
Merge pull request #55296 from shubham1206agra/revert-54736-53814-con…
a588fe3 
…firmation-button-jump

Revert "fix confirmation button jump"

(cherry picked from commit 71501b9)

(CP triggered by mountiny)
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Closed
31 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.86-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.86-3 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@shubham1206agra shubham1206agra deleted the revert-54736-53814-confirmation-button-jump branch February 3, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjasikowski mjasikowski mjasikowski approved these changes

Assignees
No one assigned
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubham1206agra @mjasikowski @OSBotify