fix: Improve visibility of tooltips #55148

truph01 · 2025-01-13T05:33:28Z

Explanation of Change

Fixed Issues

$ #54775
PROPOSAL: #54775 (comment)

Tests

Login with new account
Finish onboarding steps.
Verify the tooltip above the "+" button matches below design:

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with new account
Finish onboarding steps.
Verify the tooltip above the "+" button matches below design:

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-13T05:33:33Z

@shawnborton @ishpaul777 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

truph01 · 2025-01-13T05:34:25Z

I encountered an issue when running IOS native. I will update the evidence later

shawnborton · 2025-01-13T07:03:00Z

I think we're going to need to adjust the location of the tooltips now that we have made the pointer bigger. For instance, notice how the pointer here isn't perfectly aligned with the center point of the UI element it's pointing to?

src/styles/theme/themes/dark.ts

truph01 · 2025-01-14T10:39:31Z

Cool cool, let's keep it green100 then cc @truph01

I updated

Before	After

shawnborton · 2025-01-14T10:45:12Z

Colors look good. Now let's center up that pointer with the element it's pointing to :)

truph01 · 2025-01-14T10:52:38Z

@shawnborton I updated the position of the pointer. Result:

shawnborton · 2025-01-14T10:58:10Z

Close, but I think we may be off by 1px:

truph01 · 2025-01-14T11:07:32Z

Updated:

shawnborton · 2025-01-14T11:09:09Z

Nice, much better!

Let me know when you are at a good spot, and I will run a test build so we can test the other tooltips that show up for onboarding.

truph01 · 2025-01-14T11:13:23Z

@shawnborton I address all your feedback (here and here). So now you can trigger a test build.

github-actions · 2025-01-14T14:04:36Z

🚧 @dannymcclain has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-14T14:32:12Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55148/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55148/NewExpensify.dmg	https://55148.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-01-14T15:04:28Z

This is feeling pretty good to me, and wow on light mode these are so much more obvious than before!

Minor nitpick... is this one slightly misaligned? As in, should it be centered to the + below? It might already be like this on production though, just let me know!

ishpaul777 · 2025-01-14T18:16:58Z

These tooltips are not aligned to center, can we please align them @truph01 Thanks!

shawnborton · 2025-01-15T08:09:52Z

It also looks like there is a slight difference in border radius between these two:

The top one is correct. I know your PR isn't meant to address border radii, but perhaps you can take a look at that quickly and see if it's a simple fix we can add in here.

truph01 · 2025-01-15T09:01:13Z

These tooltips are not aligned to center, can we please align them @truph01 Thanks!

I just fixed it. Result:

Before	After

truph01 · 2025-01-15T09:38:52Z

It also looks like there is a slight difference in border radius between these two:

I just fixed. Result:

Before	After

shawnborton · 2025-01-15T09:43:57Z

Amazing, thank you! Can you also check the border radius of this one too?

I just want to make sure they all consistently use the same border radius variable and we have no discrepancies between them.

truph01 · 2025-01-15T09:51:05Z

Amazing, thank you! Can you also check the border radius of this one too?

I updated. Result:

shawnborton · 2025-01-15T09:54:50Z

Thanks! Probably time to start getting this into final review cc @ishpaul777

ishpaul777 · 2025-01-15T10:05:02Z

@truph01 please fix lint check failure, see https://expensify.slack.com/archives/C01GTK53T8Q/p1736812216518129 for guidance

src/pages/Search/SearchTypeMenu.tsx

src/styles/index.ts

ishpaul777 · 2025-01-15T19:39:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-16.at.1.38.00.AM.mov

Screen.Recording.2025-01-16.at.1.39.41.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-16.at.1.42.00.AM.mov

iOS: Native

Screen.Recording.2025-01-16.at.1.34.05.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-16.at.1.44.48.AM.mov

MacOS: Chrome / Safari

renameSavedSearch	bottomNavInboxTooltip	filterButtonTooltip

workspaceChatCreate	workspaceChatLHNTooltip	conciergeLHNGBR

quickActionButton	globalCreateTooltip

MacOS: Desktop

Screen.Recording.2025-01-16.at.1.48.51.AM.mov

justinpersaud

lgtm

I'll wait for a design approval too

dannymcclain · 2025-01-15T21:21:23Z

Screenshots/videos are looking pretty good to me. Happy to wait for @shawnborton and @dubielzyk-expensify to take a peek as well.

dubielzyk-expensify · 2025-01-16T03:04:20Z

Looks good to me too! 👍

ishpaul777 · 2025-01-16T21:22:31Z

~~@justinpersaud This is ready for merge : )~~ sorry i think this is still pending @shawnborton approval

shawnborton · 2025-01-16T21:26:30Z

Ah sorry, I missed Danny's comment. Let's Get This Merged!

shawnborton · 2025-01-16T21:26:54Z

cc @justinpersaud

shawnborton · 2025-01-16T22:14:54Z

cc @puneetlath we just merged this one!

OSBotify · 2025-01-16T22:20:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

puneetlath · 2025-01-16T22:56:58Z

Awesome!

github-actions · 2025-01-17T13:55:20Z

🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.0.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

linhvovan29546 · 2025-01-18T04:47:49Z

@ishpaul777 @justinpersaud @truph01 The FAB tooltip is broken on Android after merging this PR.

OneCameraFinalVideo.13.mp4

github-actions · 2025-01-21T08:08:24Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.87-3 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

fix: Improve visibility of tooltips

939ef06

truph01 requested review from a team as code owners January 13, 2025 05:33

melvin-bot bot requested review from ishpaul777 and shawnborton January 13, 2025 05:33

melvin-bot bot removed the request for review from a team January 13, 2025 05:33

truph01 mentioned this pull request Jan 13, 2025

[HOLD for payment 2025-01-28] [$250] Improve visibility of tooltips #54775

Closed

shawnborton reviewed Jan 13, 2025

View reviewed changes

src/styles/theme/themes/dark.ts Outdated Show resolved Hide resolved

merge main

f7d261f

fix: update fabTooltipShiftHorizontal value

146537d

fix: update fabTooltipShiftHorizontal

2e20e00

dannymcclain added the Ready To Build label Jan 14, 2025

fix: update tooltipHighlightBG

6e11fea

fix: align education tooltip

06afb59

fix: border radius

621272f

fix: border radius of tooltip composer

74f15d5

ishpaul777 reviewed Jan 15, 2025

View reviewed changes

src/pages/Search/SearchTypeMenu.tsx Outdated Show resolved Hide resolved

ishpaul777 reviewed Jan 15, 2025

View reviewed changes

src/styles/index.ts Outdated Show resolved Hide resolved

truph01 added 3 commits January 15, 2025 17:51

fix: lint

f3018e5

fix: use productTrainingTooltipWrapper and remove duplicate style

e658e65

fix: lint

2f1d127

ishpaul777 approved these changes Jan 15, 2025

View reviewed changes

melvin-bot bot requested a review from justinpersaud January 15, 2025 20:24

justinpersaud approved these changes Jan 15, 2025

View reviewed changes

shawnborton approved these changes Jan 16, 2025

View reviewed changes

justinpersaud merged commit 8c86e92 into Expensify:main Jan 16, 2025
18 checks passed

github-actions bot mentioned this pull request Jan 17, 2025

Deploy Checklist: New Expensify 2025-01-17 #55396

Closed

60 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Improve visibility of tooltips #55148

fix: Improve visibility of tooltips #55148

truph01 commented Jan 13, 2025

melvin-bot bot commented Jan 13, 2025

truph01 commented Jan 13, 2025

shawnborton commented Jan 13, 2025

truph01 commented Jan 14, 2025

shawnborton commented Jan 14, 2025

truph01 commented Jan 14, 2025

shawnborton commented Jan 14, 2025

truph01 commented Jan 14, 2025

shawnborton commented Jan 14, 2025

truph01 commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

shawnborton commented Jan 14, 2025

ishpaul777 commented Jan 14, 2025

shawnborton commented Jan 15, 2025

truph01 commented Jan 15, 2025

truph01 commented Jan 15, 2025

shawnborton commented Jan 15, 2025

truph01 commented Jan 15, 2025

shawnborton commented Jan 15, 2025

ishpaul777 commented Jan 15, 2025

ishpaul777 commented Jan 15, 2025 •

edited

Loading

justinpersaud left a comment

dannymcclain commented Jan 15, 2025

dubielzyk-expensify commented Jan 16, 2025

ishpaul777 commented Jan 16, 2025 •

edited

Loading

shawnborton commented Jan 16, 2025

shawnborton commented Jan 16, 2025

shawnborton commented Jan 16, 2025

OSBotify commented Jan 16, 2025

puneetlath commented Jan 16, 2025

github-actions bot commented Jan 17, 2025

linhvovan29546 commented Jan 18, 2025

github-actions bot commented Jan 21, 2025

fix: Improve visibility of tooltips #55148

fix: Improve visibility of tooltips #55148

Conversation

truph01 commented Jan 13, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 13, 2025

truph01 commented Jan 13, 2025

shawnborton commented Jan 13, 2025

truph01 commented Jan 14, 2025

shawnborton commented Jan 14, 2025

truph01 commented Jan 14, 2025

shawnborton commented Jan 14, 2025

truph01 commented Jan 14, 2025

shawnborton commented Jan 14, 2025

truph01 commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

shawnborton commented Jan 14, 2025

ishpaul777 commented Jan 14, 2025

shawnborton commented Jan 15, 2025

truph01 commented Jan 15, 2025

truph01 commented Jan 15, 2025

shawnborton commented Jan 15, 2025

truph01 commented Jan 15, 2025

shawnborton commented Jan 15, 2025

ishpaul777 commented Jan 15, 2025

ishpaul777 commented Jan 15, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

justinpersaud left a comment

Choose a reason for hiding this comment

dannymcclain commented Jan 15, 2025

dubielzyk-expensify commented Jan 16, 2025

ishpaul777 commented Jan 16, 2025 • edited Loading

shawnborton commented Jan 16, 2025

shawnborton commented Jan 16, 2025

shawnborton commented Jan 16, 2025

OSBotify commented Jan 16, 2025

puneetlath commented Jan 16, 2025

github-actions bot commented Jan 17, 2025

linhvovan29546 commented Jan 18, 2025

github-actions bot commented Jan 21, 2025

ishpaul777 commented Jan 15, 2025 •

edited

Loading

ishpaul777 commented Jan 16, 2025 •

edited

Loading