Fix keyboard blinks #54293

rezkiy37 · 2024-12-18T13:04:48Z

Explanation of Change

The PR fixes the keyboard blinking on the Display Name page.

Fixed Issues

$ #53078
PROPOSAL: #53078 (comment)

Tests

Display name

Open the mobile app on iOS.
Navigate to Settings > Profile > Display name.
Tap into First Name so that the keyboard pulls up.
Tap into Last Name (keyboard should stay up).
Tap between the FN and LN inputs a few times.
The keyboard shouldn’t blink when the focus is changed

Legal name

Open the mobile app on iOS.
Navigate to Settings > Profile > Legal name.
Tap into First Name so that the keyboard pulls up.
Tap into Last Name (keyboard should stay up).
Tap between the FN and LN inputs a few times.
The keyboard shouldn’t blink when the focus is changed

Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

Test.mp4

IOS.mp4

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Chrome.mp4

MacOS: Desktop

Desktop.mp4

…inputs

…/53078-keyboard-blicks-2

…Page

rezkiy37 · 2024-12-19T15:18:04Z

Currently, I struggle (Slack) to build Android and open iOS: mWeb Safari. So I am opening w/o those platforms. I am kindly asking a C+ reviewer to verify the platforms.

…ePage

melvin-bot · 2024-12-19T15:25:39Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-12-20T04:33:40Z

src/pages/settings/Profile/DisplayNamePage.tsx

@@ -111,7 +111,7 @@ function DisplayNamePage({currentUserPersonalDetails}: DisplayNamePageProps) {
                            role={CONST.ROLE.PRESENTATION}
                            defaultValue={currentUserDetails.lastName ?? ''}
                            spellCheck={false}
-                            isMarkdownEnabled
+                            autoCapitalize="words"


@rezkiy37 I think we should add the same fix to LegalNamePgae for consistency

It definetely makes sense.

DylanDylann · 2024-12-20T04:39:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-20.at.11.36.02.mov

Android: mWeb Chrome

Screen.Recording.2024-12-20.at.11.35.00.mov

iOS: Native

Screen.Recording.2024-12-20.at.11.38.32.mov

iOS: mWeb Safari

Screen.Recording.2024-12-20.at.11.36.24.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-20.at.11.32.11.mov

MacOS: Desktop

Screen.Recording.2024-12-20.at.11.33.01.mov

DylanDylann · 2024-12-20T04:39:56Z

@rezkiy37 The rest looks good to me. Please ping me when you update this comment

rezkiy37 · 2024-12-20T09:28:11Z

@rezkiy37 I think we should add the same fix to LegalNamePgae for consistency

@DylanDylann, I've applied it - f7dc051 and updated the test steps.

Video

IOS.mp4

OSBotify · 2024-12-20T11:03:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-23T20:59:13Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2024-12-23T21:43:09Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-23T21:50:39Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:06:24Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T00:54:03Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T19:44:10Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-24T20:01:06Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-26T20:28:21Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Update DisplayNamePage to use autoCapitalize for first and last name …

c26a7f5

…inputs

rezkiy37 mentioned this pull request Dec 18, 2024

[WIP] Fix keyboard blicks #54254

Closed

50 tasks

rezkiy37 changed the title ~~[WIP] Fix keyboard blicks~~ [WIP] Fix keyboard blinks Dec 18, 2024

rezkiy37 added 2 commits December 19, 2024 12:52

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fix…

a8d9f44

…/53078-keyboard-blicks-2

Enable Markdown support for first and last name fields in DisplayName…

3ec344e

…Page

Remove Markdown support from first and last name fields in DisplayNam…

1a18f99

…ePage

rezkiy37 marked this pull request as ready for review December 19, 2024 15:25

rezkiy37 requested a review from a team as a code owner December 19, 2024 15:25

melvin-bot bot requested review from DylanDylann and removed request for a team December 19, 2024 15:25

rezkiy37 changed the title ~~[WIP] Fix keyboard blinks~~ Fix keyboard blinks Dec 19, 2024

rezkiy37 mentioned this pull request Dec 19, 2024

[HOLD for payment 2025-01-02] [$250] iOS - Profile - Display Name - Keyboard blinks when focus is changed #53078

Closed

8 tasks

DylanDylann reviewed Dec 20, 2024

View reviewed changes

Add autoCapitalize attribute to LegalNamePage input fields

f7dc051

rezkiy37 requested a review from DylanDylann December 20, 2024 09:29

DylanDylann approved these changes Dec 20, 2024

View reviewed changes

melvin-bot bot requested a review from MariaHCD December 20, 2024 09:34

MariaHCD approved these changes Dec 20, 2024

View reviewed changes

MariaHCD merged commit 78337bd into Expensify:main Dec 20, 2024
18 checks passed

Themoonalsofall mentioned this pull request Dec 23, 2024

Remove display name markdown #53903

Closed

50 tasks

github-actions bot mentioned this pull request Dec 23, 2024

Deploy Checklist: New Expensify 2024-12-23 #54476

Closed

parasharrajat mentioned this pull request Dec 31, 2024

[$250] iOS Hybrid - Profile - Keyboard flickers when changing between First Name and Last Name #54672

Closed

8 tasks

Themoonalsofall mentioned this pull request Jan 6, 2025

[$250] Profile - Display name field displays live mark down when entering text with mark down #53336

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix keyboard blinks #54293

Fix keyboard blinks #54293

rezkiy37 commented Dec 18, 2024 •

edited

Loading

rezkiy37 commented Dec 19, 2024 •

edited

Loading

melvin-bot bot commented Dec 19, 2024

DylanDylann Dec 20, 2024

rezkiy37 Dec 20, 2024

DylanDylann commented Dec 20, 2024

DylanDylann commented Dec 20, 2024

rezkiy37 commented Dec 20, 2024

OSBotify commented Dec 20, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

Fix keyboard blinks #54293

Fix keyboard blinks #54293

Conversation

rezkiy37 commented Dec 18, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Display name

Legal name

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 commented Dec 19, 2024 • edited Loading

melvin-bot bot commented Dec 19, 2024

DylanDylann Dec 20, 2024

Choose a reason for hiding this comment

rezkiy37 Dec 20, 2024

Choose a reason for hiding this comment

DylanDylann commented Dec 20, 2024

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Dec 20, 2024

rezkiy37 commented Dec 20, 2024

OSBotify commented Dec 20, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

rezkiy37 commented Dec 18, 2024 •

edited

Loading

rezkiy37 commented Dec 19, 2024 •

edited

Loading