-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding tasks copy change for settings tab #52653
Conversation
Here's a draft PR for the copy changes. I'm asking @mountiny if I need to update the copy in these tests in Web-E as well to match. If not, this can be converted to ready to review. |
I think I lost Vit to the Friday beers, so I'll pick this up again on Monday. |
Hiya Tom, going to test an AI feature on this, shouldn't affect anything just seeing how it works in practice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Fancy! |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Web-E PR for the tests using this copy here: https://github.com/Expensify/Web-Expensify/pull/44464 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one comment
Co-authored-by: Vit Horacek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.64-0 🚀
|
This PR is failing foe Web because of issue #52760 |
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.64-4 🚀
|
CC: @jamesdeanexpensify
Explanation of Change
The first line of most onboarding tasks read "Click your profile picture" and we've observed people getting confused figuring out where that is, recognising that they don't have a profile picture uploaded at the start of their onboarding journey. We've now also labelled the bottom tabs, for which this one is called "Settings".
As such, this is a PR to update the copy of "Click your profile picture." to "Click the settings tab." to hopefully improve discovery.
Fixed Issues
https://expensify.slack.com/archives/C07HPDRELLD/p1731416159397859
Tests
None
Offline tests
None
QA Steps
Marked this is a NO QA as it's just a copy change, but you can see these tasks with the following steps:
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
None