Fix editing a task, navigate app to other report #51381

tsa321 · 2024-10-24T06:29:26Z

Details

Fixed Issues

$ #47671
PROPOSAL: #47671 (comment)

Tests

Go to any chat and create a task.
Open the task report.
Send 10 messages.
Edit the task description and save it.
Verify that the app doesn't navigate to another report and that the task report doesn't automatically scroll to the bottom.
Edit the task title.
Verify that the app doesn't navigate to another report and that the task report doesn't automatically scroll to the bottom.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to any chat and create a task.
Open the task report.
Send 10 messages.
Edit the task description and save it.
Verify that the app doesn't navigate to another report and that the task report doesn't automatically scroll to the bottom.
Edit the task title.
Verify that the app doesn't navigate to another report and that the task report doesn't automatically scroll to the bottom.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-d.mp4

Android: mWeb Chrome

android-mweb_d.mp4

iOS: Native

ios-native_d.mp4

iOS: mWeb Safari

ios-msfari_d.mp4

MacOS: Chrome / Safari

macos-web-d.mp4

MacOS: Desktop

macos-desktop_d.mp4

Signed-off-by: Tsaqif <[email protected]>

melvin-bot · 2024-10-24T06:29:32Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2024-11-04T14:06:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-20.at.1.09.48.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2024-11-04.at.5.49.29.in.the.afternoon.mov

iOS: Native

Screen.Recording.2024-11-20.at.1.29.46.in.the.afternoon.mov

iOS: mWeb Safari

Screen.Recording.2024-11-04.at.5.32.57.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-04.at.5.19.47.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2024-11-20.at.1.26.01.in.the.afternoon.mov

getusha · 2024-11-04T14:59:11Z

@tsa321 strangely it kind of scrolls on android native after changing the description

Screen.Recording.2024-11-04.at.5.57.22.in.the.afternoon.mov

tsa321 · 2024-11-05T01:59:37Z

@getusha, it looks like the Android issue is related to the appearance of the keyboard / the focus of the composer.

As you can see in the main, if we open the description page and then press the back button, the report scrolls:

backButtonOnMain.mp4

This issue only occurs if the composer was previously focused. If the composer is not focused beforehand, the report does not scroll:

test3.mp4

This bug is related to the keyboard appearing and also occurs in the main.
To confirm whether this issue also occurs in the main, you can test it by tapping the back button in the header of the edit description page (without editing the description). The report will scroll slightly after the keyboard appears.

tsa321 · 2024-11-09T00:47:34Z

@getusha: So basically, the scroll bug on Android is unrelated to the issue. To confirm this, you can reproduce the bug even without editing a task.

You can test it by tapping the back button in the header of the Edit Description page (without editing the description). The report will scroll slightly after the keyboard appears:

backButtonOnMain.mp4

getusha · 2024-11-09T01:38:48Z

@tsa321 the expected behavior is for it not to scroll after we edit the description/title. It does seem related to me

tsa321 · 2024-11-09T02:13:34Z

@getusha, the bug exists even without editing the task, as I mentioned here. Also, that bug is that the report scrolls a little in Android, while the bug we are trying to fix is that the report scrolls to the bottom.
If it needs to be fixed, I can create a follow-up PR, but it's unrelated to the issue that this PR is trying to address.

I believe the bug is related to this file:
https://github.com/Expensify/App/blob/main/src/components/FlatList/index.android.tsx

Also, I think @janicduplessis has more context on the bug.

cc @deetergp

tsa321 · 2024-11-14T00:31:06Z

@deetergp Is this really a bug or the expected behavior?

keyboard-showup.mp4

When a user opens the keyboard, the text above the composer stays positioned right above it, which results in the upper portion of the report being hidden.

I believe this is expected behavior.

tsa321 · 2024-11-14T13:44:53Z

@getusha to fix the issue, the auto focus must be disabled in android/ ios, so the keyboard doesn't push the report screen.

deetergp · 2024-11-18T20:01:25Z

I don't really understand what the bug might be. @getusha could you clarify for me what you feel is the expected behavior here? From what I see in the videos posted in this PR, it looks like it is behaving the way it ought to, so I am a little confused.

getusha · 2024-11-20T10:06:13Z

It appears to scroll to the bottom when the composer is re-focused, seems like it has a different root cause as @tsa321 mentioned.

Screen.Recording.2024-11-20.at.1.05.34.in.the.afternoon.mov

getusha · 2024-11-20T10:33:08Z

src/libs/actions/Task.ts

@@ -1102,7 +1102,7 @@ function deleteTask(report: OnyxEntry<OnyxTypes.Report>) {
    };

    API.write(WRITE_COMMANDS.CANCEL_TASK, parameters, {optimisticData, successData, failureData});
-    Report.notifyNewAction(report.reportID, currentUserAccountID);


Is this necessary for deleteTask?

I will revert this

I think you forgot to push the changes

tsa321 · 2024-11-20T13:22:46Z

It appears to scroll to the bottom when the composer is re-focused, seems like it has a different root cause @tsa321 mentioned.
Screen.Recording.2024-11-20.at.1.05.34.in.the.afternoon.mov

@getusha Could you rephrase this? I don't quite understand what you mean.

To test the bug you mentioned, you need to have a lot of text in the reports, for example, more than 50 messages, to ensure that the bug either scrolls a bit or scrolls to the bottom.

getusha · 2024-11-20T14:20:42Z

@tsa321 we discussed this before #51381 (comment)

getusha · 2024-11-20T15:43:59Z

I believe the issue is that the scroll doesn't go all the way to the bottom; it only scrolls a bit.

Yes, @tsa321 i said it has a different root cause 😄

seems like it has a different root cause @tsa321 mentioned.

I am just answering for #51381 (comment)

tsa321 · 2024-11-21T00:00:08Z

@getusha Oh ok, sorry I misunderstood.

Signed-off-by: Tsaqif <[email protected]>

tsa321 · 2024-11-21T00:05:35Z

@getusha I have reverted the changes in the deleteTask

getusha

this one is good to go!

deetergp

I don't really think we need the comments—let's drop them.

Signed-off-by: Tsaqif <[email protected]>

tsa321 · 2024-11-28T06:42:47Z

@deetergp I have removed the comments.

Fix editing a task, navigate app to other report

08ff8aa

Signed-off-by: Tsaqif <[email protected]>

tsa321 requested a review from a team as a code owner October 24, 2024 06:29

melvin-bot bot requested review from getusha and removed request for a team October 24, 2024 06:29

Merge branch 'main' into fixEditTaskNav

5f4c4db

getusha reviewed Nov 20, 2024

View reviewed changes

tsa321 requested a review from getusha November 20, 2024 13:25

This comment was marked as resolved.

Sign in to view

revert some changes

35238fb

Signed-off-by: Tsaqif <[email protected]>

getusha approved these changes Nov 26, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp November 26, 2024 19:32

deetergp requested changes Nov 27, 2024

View reviewed changes

remove comments

7b3630a

Signed-off-by: Tsaqif <[email protected]>

tsa321 requested a review from deetergp November 28, 2024 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix editing a task, navigate app to other report #51381

Fix editing a task, navigate app to other report #51381

tsa321 commented Oct 24, 2024

melvin-bot bot commented Oct 24, 2024

getusha commented Nov 4, 2024 •

edited

Loading

getusha commented Nov 4, 2024

tsa321 commented Nov 5, 2024 •

edited

Loading

tsa321 commented Nov 9, 2024

getusha commented Nov 9, 2024

tsa321 commented Nov 9, 2024 •

edited

Loading

tsa321 commented Nov 14, 2024

tsa321 commented Nov 14, 2024

deetergp commented Nov 18, 2024

getusha commented Nov 20, 2024 •

edited

Loading

getusha Nov 20, 2024

tsa321 Nov 20, 2024

getusha Nov 20, 2024

tsa321 commented Nov 20, 2024 •

edited

Loading

getusha commented Nov 20, 2024

This comment was marked as resolved.

getusha commented Nov 20, 2024

tsa321 commented Nov 21, 2024

tsa321 commented Nov 21, 2024

getusha left a comment

deetergp left a comment

tsa321 commented Nov 28, 2024

Fix editing a task, navigate app to other report #51381

Are you sure you want to change the base?

Fix editing a task, navigate app to other report #51381

Conversation

tsa321 commented Oct 24, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 24, 2024

getusha commented Nov 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha commented Nov 4, 2024

tsa321 commented Nov 5, 2024 • edited Loading

tsa321 commented Nov 9, 2024

getusha commented Nov 9, 2024

tsa321 commented Nov 9, 2024 • edited Loading

tsa321 commented Nov 14, 2024

tsa321 commented Nov 14, 2024

deetergp commented Nov 18, 2024

getusha commented Nov 20, 2024 • edited Loading

getusha Nov 20, 2024

Choose a reason for hiding this comment

tsa321 Nov 20, 2024

Choose a reason for hiding this comment

getusha Nov 20, 2024

Choose a reason for hiding this comment

tsa321 commented Nov 20, 2024 • edited Loading

getusha commented Nov 20, 2024

This comment was marked as resolved.

getusha commented Nov 20, 2024

tsa321 commented Nov 21, 2024

tsa321 commented Nov 21, 2024

getusha left a comment

Choose a reason for hiding this comment

deetergp left a comment

Choose a reason for hiding this comment

tsa321 commented Nov 28, 2024

getusha commented Nov 4, 2024 •

edited

Loading

tsa321 commented Nov 5, 2024 •

edited

Loading

tsa321 commented Nov 9, 2024 •

edited

Loading

getusha commented Nov 20, 2024 •

edited

Loading

tsa321 commented Nov 20, 2024 •

edited

Loading