-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Submit button hang in middle page #51318
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3606eb4
fix: Submit button hang in middle page
truph01 da303ba
merge main
truph01 3378345
merge main
truph01 dfb70a5
fix: Submit button hang in middle when selecting participant
truph01 d506dcd
merge main
truph01 8836b75
fix: revert the fix when choosing participants
truph01 744b0cc
merge main
truph01 9508d05
merge main
truph01 937064c
fix: create useIsWindowHeightReducedByKeyboard hook
truph01 9c4e662
add comment to useEffect
truph01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import {useCallback, useEffect, useState} from 'react'; | ||
import usePrevious from '@hooks/usePrevious'; | ||
import useResponsiveLayout from '@hooks/useResponsiveLayout'; | ||
import useWindowDimensions from '@hooks/useWindowDimensions'; | ||
|
||
const useIsWindowHeightReducedByKeyboard = () => { | ||
const [isWindowHeightReducedByKeyboard, setIsWindowHeightReducedByKeyboard] = useState(false); | ||
const {windowHeight} = useWindowDimensions(); | ||
const prevWindowHeight = usePrevious(windowHeight); | ||
const {shouldUseNarrowLayout} = useResponsiveLayout(); | ||
const toggleKeyboardOnSmallScreens = useCallback( | ||
(isKBOpen: boolean) => { | ||
if (!shouldUseNarrowLayout) { | ||
return; | ||
} | ||
setIsWindowHeightReducedByKeyboard(isKBOpen); | ||
}, | ||
[shouldUseNarrowLayout], | ||
); | ||
useEffect(() => { | ||
if (!isWindowHeightReducedByKeyboard && windowHeight < prevWindowHeight - 100) { | ||
toggleKeyboardOnSmallScreens(true); | ||
} else if (isWindowHeightReducedByKeyboard && windowHeight > prevWindowHeight) { | ||
toggleKeyboardOnSmallScreens(false); | ||
} | ||
}, [isWindowHeightReducedByKeyboard, prevWindowHeight, toggleKeyboardOnSmallScreens, windowHeight]); | ||
|
||
return isWindowHeightReducedByKeyboard; | ||
}; | ||
|
||
export default useIsWindowHeightReducedByKeyboard; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add comments for this effect? Copying from PDFView/index.tsx should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added comment