Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: App returns to card feed selection page after issuing a card from member profile #50597

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fix: App returns to card feed selection page after issuing a card from member profile #50597

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb29c7b
Fix: App returns to card feed selection page after issuing a card fro…
abzokhattab Oct 10, 2024
f60884a
Fix eslint
abzokhattab Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/workspace/members/WorkspaceMemberNewCardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
return;
}
if (selectedFeed === CONST.EXPENSIFY_CARD.NAME) {
const activeRoute = Navigation.getActiveRoute();

Check failure on line 75 in src/pages/workspace/members/WorkspaceMemberNewCardPage.tsx

View workflow job for this annotation

GitHub Actions / ESLint check 

'activeRoute' is assigned a value but never used

Check failure on line 75 in src/pages/workspace/members/WorkspaceMemberNewCardPage.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

'activeRoute' is assigned a value but never used

Card.setIssueNewCardStepAndData({
step: CONST.EXPENSIFY_CARD.STEP.CARD_TYPE,
Expand All @@ -81,7 +81,7 @@
},
isEditing: false,
});
Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID, activeRoute));
Navigation.navigate(ROUTES.WORKSPACE_EXPENSIFY_CARD_ISSUE_NEW.getRoute(policyID, ROUTES.WORKSPACE_MEMBER_DETAILS.getRoute(policyID, accountID)));

Check failure on line 84 in src/pages/workspace/members/WorkspaceMemberNewCardPage.tsx

View workflow job for this annotation

GitHub Actions / ESLint check 

Delete `········`

Check failure on line 84 in src/pages/workspace/members/WorkspaceMemberNewCardPage.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Delete `········`
abzokhattab marked this conversation as resolved.
Show resolved Hide resolved
} else {
CompanyCards.setAssignCardStepAndData({
currentStep: CONST.COMPANY_CARD.STEP.CARD,
Expand Down
Loading