Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] fix(ci): e2e builds failing due to artifact name mismatch #50582

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[NoQA] fix(ci): e2e builds failing due to artifact name mismatch #50582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5dee21
fix: e2e builds failing due to artifact name mismatch
hannojg Oct 10, 2024
c3575f5
fix get name
hannojg Oct 10, 2024
58bec9c
fix name to APK_ARTIFACT_NAME
hannojg Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/buildAndroid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,14 @@ on:
description: The pull request number associated with this build, if relevant.
type: string
required: false

outputs:
AAB_FILE_NAME:
value: ${{ jobs.build.outputs.AAB_FILE_NAME }}
APK_FILE_NAME:
value: ${{ jobs.build.outputs.APK_FILE_NAME }}
APK_ARTIFACT_NAME:
value: ${{ jobs.build.outputs.APK_ARTIFACT_NAME }}

workflow_dispatch:
inputs:
Expand Down Expand Up @@ -56,6 +59,7 @@ jobs:
outputs:
AAB_FILE_NAME: ${{ steps.build.outputs.AAB_FILE_NAME }}
APK_FILE_NAME: ${{ steps.build.outputs.APK_FILE_NAME }}
APK_ARTIFACT_NAME: ${{ steps.build.outputs.APK_ARTIFACT_NAME }}

steps:
- name: Checkout
Expand Down Expand Up @@ -159,6 +163,7 @@ jobs:
echo "APK_PATH=$apkPath"
echo "APK_FILE_NAME=$(basename "$apkPath")"
echo "SHOULD_UPLOAD_SOURCEMAPS=$SHOULD_UPLOAD_SOURCEMAPS"
echo "APK_ARTIFACT_NAME=${{ inputs.artifact-prefix }}android-artifact-apk" >> "$GITHUB_OUTPUT"
} >> "$GITHUB_OUTPUT"

- name: Upload Android AAB artifact
Expand All @@ -174,7 +179,7 @@ jobs:
continue-on-error: true
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.artifact-prefix }}android-artifact-apk
name: ${{ steps.build.outputs.APK_ARTIFACT_NAME }}
path: ${{ steps.build.outputs.APK_PATH }}

- name: Upload Android sourcemaps artifact
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2ePerformanceTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ jobs:
uses: actions/download-artifact@v4
id: downloadBaselineAPK
with:
name: baseline-${{ needs.prep.outputs.BASELINE_VERSION }}-android-artifact-apk
name: ${{ needs.buildBaseline.outputs.APK_ARTIFACT_NAME }}
path: zip
# Set github-token only if the baseline was built in this workflow run:
github-token: ${{ needs.prep.outputs.BASELINE_ARTIFACT_WORKFLOW_ID && github.token }}
Expand All @@ -139,7 +139,7 @@ jobs:
uses: actions/download-artifact@v4
id: downloadDeltaAPK
with:
name: delta-${{ needs.prep.outputs.DELTA_REF }}-android-artifact-apk
name: ${{ needs.buildDelta.outputs.APK_ARTIFACT_NAME }}
path: zip

- name: Rename delta APK
Expand Down
Loading