Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled prop on submit button #4982

Conversation

anthony-hull
Copy link
Contributor

@anthony-hull anthony-hull commented Sep 1, 2021

Details

Submit button for setting password is now disabled when the form is not valid

Fixed Issues

#4731

Tests

setpassword.disable.mp4

QA Steps

  1. log out
  2. set LS key "credentials": {"login":"[email protected]"}
  3. navigate to:
  4. https://localhost:8080/setpassword/123/123
  5. verify the submit button is disabled
  6. enter passwords into the boxes that are valid and match
  7. verify the submit button is enabled and works

Tested On

  • Web

@anthony-hull anthony-hull requested a review from a team as a code owner September 1, 2021 14:53
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team September 1, 2021 14:53
@marcaaron marcaaron merged commit d1e85c9 into Expensify:main Sep 1, 2021
@marcaaron
Copy link
Contributor

@anthony-hull please test on all platforms in the future. There is a PR template for a reason.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2021

🚀 Deployed to staging by @marcaaron in version: 1.0.91-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Sep 3, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-10. 🎊

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.92-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mountiny
Copy link
Contributor

mountiny commented Sep 3, 2021

@anthony-hull Thank you for your contribution here 🎉

I just wanted to bring to you attention this post from Slack about how to format the linked issues in your PRs. Please, keep that in mind for I hope many more PRs to come 😄 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants