-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow builds to distribute to external testers #4961
Conversation
|
Merging to CP to start testing. |
Allow builds to distribute to external testers (cherry picked from commit fae6e0e)
🚀 Cherry-picked to staging by @AndrewGable in version: 1.0.90-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
🚀 Deployed to staging by @AndrewGable in version: 1.0.90-3 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.0.91-0 🚀
|
Just confirmed that case 1 is being handled correctly: |
Details
I am curious to see what happens when we have
distribute_external
set to true andreject_build_waiting_for_review
set to false (the default) and we have a build in review. I think it might fail in these instances, but I want to make sure this throws an error only in that case, then in all other cases it does distribute the build to testers.Fixed Issues
$ #2748
Tests