Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow builds to distribute to external testers #4961

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

AndrewGable
Copy link
Contributor

Details

I am curious to see what happens when we have distribute_external set to true and reject_build_waiting_for_review set to false (the default) and we have a build in review. I think it might fail in these instances, but I want to make sure this throws an error only in that case, then in all other cases it does distribute the build to testers.

Fixed Issues

$ #2748

Tests

  1. Merge this PR
  2. Let's see if the build is available for testers to use immediately (it should be)
  3. When a new version is submitted, let's make sure it's put into review (it should be)
  4. Let's watch and see what happens when another build is submitted when 3 is in review (it might error, but let's see)

@AndrewGable AndrewGable requested a review from a team as a code owner August 31, 2021 22:26
@AndrewGable AndrewGable self-assigned this Aug 31, 2021
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team August 31, 2021 22:26
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@AndrewGable
Copy link
Contributor Author

Merging to CP to start testing.

@AndrewGable AndrewGable merged commit fae6e0e into main Aug 31, 2021
@AndrewGable AndrewGable deleted the andrew-distribute-external branch August 31, 2021 23:11
github-actions bot pushed a commit that referenced this pull request Aug 31, 2021
Allow builds to distribute to external testers

(cherry picked from commit fae6e0e)
@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Cherry-picked to staging by @AndrewGable in version: 1.0.90-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@AndrewGable
Copy link
Contributor Author

Screen Shot 2021-08-31 at 6 20 30 PM

This worked for test step 2 🎉 I will keep an eye on future builds and see if any do not work and fix them when we figure out a case that doesn't work.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

🚀 Deployed to staging by @AndrewGable in version: 1.0.90-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.91-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@AndrewGable
Copy link
Contributor Author

Just confirmed that case 1 is being handled correctly:

Screen Shot 2021-09-02 at 11 48 43 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants