Grab iOS version from release event

[AndrewGable]

Details

Uses the release event's tag to send to fastlane, to determine which version to promote to iOS production. It looks like the old ios.yml used to rely on bumpVersion.js to set this in the env which we cannot rely on anymore

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/175849

Tests

1. I tested this syntax here: https://github.com/Andrew-Test-Org/Public-Test-Repo/runs/3476298417?check_suite_focus=true
2. In order to fully test this, we will need to merge this and wait until we fully deploy a checklist

[roryabraham]

Nice, I have one question and two comments:

• Do we need to set the iOS version conditionally? i.e: can we set this environment variable for both prod and non-prod builds?
• Let's use fromJSON instead of string comparison
• Also, let's add a second line to the new step to just echo the IOS_VERSION environment variable to the console. Seems like useful debugging information.

[roryabraham]

Also, should we get rid of the old code in bumpVersion.js that we once relied on to set the environment variable? Since then, we've kinda determined that relying on side-effects in actions is a bad practice.

[AndrewGable]

Do we need to set the iOS version conditionally? i.e: can we set this environment variable for both prod and non-prod builds?

We can, but it's not needed for staging as the version comes from elsewhere and additionally the release event won't be set

Let's use fromJSON instead of string comparison

Committed your suggestion!

Also, let's add a second line to the new step to just echo the IOS_VERSION environment variable to the console. Seems like useful debugging information.

👍

Also, should we get rid of the old code in bumpVersion.js that we once relied on to set the environment variable? Since then, we've kinda determined that relying on side-effects in actions is a bad practice.

We can remove the code in bumpVersion.js that sets the environment variable, but I don't think there is code that relies on it being set in JS. The only code that relied on it being set was the workflow that I am editing.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @roryabraham in version: 1.0.90-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅