Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate withWritableReportOrNotFound from withOnyx to useOnyx #49200

Merged
merged 10 commits into from
Sep 26, 2024
Merged

Migrate withWritableReportOrNotFound from withOnyx to useOnyx #49200

merged 10 commits into from
Sep 26, 2024

Commits on Sep 19, 2024

  1. chore: migrate withWritableReportOrNotFound from withOnyx to useOnyx

    @abhinaybathina
    abhinaybathina committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    90968b8 View commit details
    Browse the repository at this point in the history

  2. chore: update TypeScript types

    @abhinaybathina
    abhinaybathina committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bd4712a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/Expensify/App into 49110-mi… 

    …gration-to-useOnyx
    @abhinaybathina
    abhinaybathina committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    676c588 View commit details
    Browse the repository at this point in the history

  4. minor: refactor

    @abhinaybathina
    abhinaybathina committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0415fe3 View commit details
    Browse the repository at this point in the history

  5. chore: code review changes

    @abhinaybathina
    abhinaybathina committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ed9659d View commit details
    Browse the repository at this point in the history

  6. chore: move useOnyx calls to top for readability and use '-1' instead… 

    … of 1 for missing reportID
    @abhinaybathina
    abhinaybathina committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    185504b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. fix: create a variable for reportOrDefault to pass report as it is to… 

    … child component
    @abhinaybathina
    abhinaybathina committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    69aba44 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/Expensify/App into 49110-mi… 

    …gration-to-useOnyx
    @abhinaybathina
    abhinaybathina committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    eb18337 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. chore: don't pass isLoadingApp into the wrapped component

    @abhinaybathina
    abhinaybathina committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    f616bab View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. refactor: remove reportOrDraft variable and pass default value to can… 

    …UserPerformWriteAction function only
    @abhinaybathina
    abhinaybathina committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    edf4ee7 View commit details
    Browse the repository at this point in the history