-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string comparison to boolean expressions #4915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are they not real booleans? Is that a GH Actions thing or are we holding it wrong?
I think this is a subtle thing with GH actions where inputs and outputs to jobs and actions are always JSON-encoded. So what was a boolean in one job becomes a string in another |
|
Let's see if this works 🤞 |
Seems like it did not work 100%, but has much less severe issues than before: https://github.com/Expensify/App/runs/3465096540?check_suite_focus=true |
🚀 Deployed to staging by @roryabraham in version: 1.0.89-0 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀
|
Details
Hopefully fixed a myriad of GH workflow failures caused by this PR
Fixed Issues
$ n/a
Tests
Same as #4796
QA Steps
None.