Remove Growl from VBA flow, for non-server errors

[Julesssss]

Details

Removes the Growl for non-server errors, as these are displayed in the error Modal. Server errors are not yet displayed in the error Modal, so we need to continue to show with the Growl.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/175331

Tests

0) Test Setup

• Create a new user
• From the global create menu, tap 'New Workspace', then the 'Get Started' button
• Tap 'Connect Manually' and use the data from this StackOverflow post to fill the Routing and Account number

1) Verify that Modal validation errors DO NOT show as a Growl

• Using the stack overflow post, fill each field except 'Company Website', leave that as https://
• Hit 'Save & Continue'
• You should see the Company Website field highlighted red with an error message
• You should see a Modal popup with an error message
• You should NOT see a Growl with the same message

2) Verify that server errors DO show as a Growl

• Continue from the end of test 1
• Enter a valid website
• Set the 'Phone Number' field to 12345678
• Hit 'Save & Continue'
• You should see a Growl with an error message
• You should NOT see the field highlighted red
• You should NOT see a Modal popup

2) Verify that unhandled validation errors DO show as a Growl

• Continue from the end of test 2
• Enter valid information in every field
• Hit 'Save & Continue'
• At the 'Requestor Information' step, enter first and second name only
• Hit 'Save & Continue'
• Fix each error one by one, ensure a Growl message shows for each
• These will be changed to Modal validation in a separate issue

QA Steps

Run above tests

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[Julesssss]

I didn't assign PullerBear... 😕

I have another commit that I was testing, will raise a new PR for it now.

[marcaaron]

NAB, I'm not sure it's necessary to wait for this promise. IIRC we don't want to do it as a convention or something to avoid unnecessary synchronous code.

[Julesssss]

Good point

[OSBotify]

🚀 Deployed to staging by @nkuoch in version: 1.0.88-3 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅